Skip to content

fix(security): inherit patched Maven JDK images #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danbao merged 2 commits into from
Oct 22, 2026
Merged

fix(security): inherit patched Maven JDK images #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dee15f7
fix(security): inherit JDK CVE-2026-91403 mitigation
danbao Oct 22, 2026
ec41685
ci: validate upgrade pull requests before publication
danbao Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ on:
- 'Dockerfile'
- 'versions/**'
- '.github/workflows/build.yml'
pull_request:
paths:
- 'Dockerfile'
- 'versions/**'
- '.github/workflows/build.yml'
workflow_dispatch:
inputs:
version:
Expand Down Expand Up @@ -59,12 +64,14 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Login to Docker Hub
if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request'
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_HUB_USERNAME }}
password: ${{ secrets.DOCKER_HUB_PASSWORD }}

- name: Login to GitHub Container Registry
if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request'
uses: docker/login-action@v3
with:
registry: ghcr.io
Expand Down Expand Up @@ -102,7 +109,8 @@ jobs:
context: .
file: ./Dockerfile
platforms: linux/amd64,linux/arm64
push: true
pull: true
push: ${{ github.ref == 'refs/heads/master' && github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
build-args: |
NODE_VERSION=${{ matrix.node_version }}
Expand All @@ -111,7 +119,7 @@ jobs:
cache-to: type=gha,mode=max,scope=${{ matrix.name }}

- name: Run Trivy vulnerability scanner
if: steps.build.outcome == 'success'
if: steps.build.outcome == 'success' && github.ref == 'refs/heads/master' && github.event_name != 'pull_request'
uses: aquasecurity/trivy-action@master
with:
image-ref: ${{ env.DOCKER_HUB_IMAGE }}:${{ matrix.node_version }}-jdk${{ matrix.jdk_version }}
Expand All @@ -121,12 +129,13 @@ jobs:

- name: Upload Trivy scan results to GitHub Security tab
uses: github/codeql-action/upload-sarif@v4
if: steps.build.outcome == 'success'
if: steps.build.outcome == 'success' && github.ref == 'refs/heads/master' && github.event_name != 'pull_request'
with:
sarif_file: 'trivy-results.sarif'

update-readme:
needs: build
if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request'
runs-on: ubuntu-latest
permissions:
contents: write
Expand Down Expand Up @@ -171,7 +180,7 @@ jobs:
```bash
docker build \
--build-arg NODE_VERSION=22.23.4 \
--build-arg MAVEN_TAG=3.9.15-jdk21.0.10-noble \
--build-arg MAVEN_TAG=3.9.15-jdk21.0.12.1-noble \
-t my-node:22-jdk21 .
```

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Parameterized Node + Maven + JDK Dockerfile
#
# Build example:
# docker build --build-arg NODE_VERSION=22.23.4 --build-arg MAVEN_TAG=3.9.15-jdk21.0.10-noble .
# docker build --build-arg NODE_VERSION=22.23.4 --build-arg MAVEN_TAG=3.9.15-jdk21.0.12.1-noble .

ARG NODE_VERSION=22.23.4
ARG MAVEN_TAG=3.9.15-jdk21.0.10-noble
ARG MAVEN_TAG=3.9.15-jdk21.0.12.1-noble

FROM docker.io/library/node:${NODE_VERSION}-slim AS node

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ docker run -it ringcentral/node:22-jdk21 node --version
```bash
docker build \
--build-arg NODE_VERSION=22.23.4 \
--build-arg MAVEN_TAG=3.9.15-jdk21.0.10-noble \
--build-arg MAVEN_TAG=3.9.15-jdk21.0.12.1-noble \
-t my-node:22-jdk21 .
```

Expand Down
30 changes: 15 additions & 15 deletions versions/versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,119 +5,119 @@
"node_version": "22.23.4",
"node_major": "22",
"jdk_version": "8",
"maven_tag": "3.8.9-jdk8u482-noble",
"maven_tag": "3.8.9-jdk8u504-noble",
"is_latest": false
},
{
"name": "node24-jdk8",
"node_version": "24.22.1",
"node_major": "24",
"jdk_version": "8",
"maven_tag": "3.8.9-jdk8u482-noble",
"maven_tag": "3.8.9-jdk8u504-noble",
"is_latest": false
},
{
"name": "node26-jdk8",
"node_version": "26.12.1",
"node_major": "26",
"jdk_version": "8",
"maven_tag": "3.8.9-jdk8u482-noble",
"maven_tag": "3.8.9-jdk8u504-noble",
"is_latest": false
},
{
"name": "node22-jdk11",
"node_version": "22.23.4",
"node_major": "22",
"jdk_version": "11",
"maven_tag": "3.9.15-jdk11.0.30-noble",
"maven_tag": "3.9.15-jdk11.0.32.1-noble",
"is_latest": false
},
{
"name": "node24-jdk11",
"node_version": "24.22.1",
"node_major": "24",
"jdk_version": "11",
"maven_tag": "3.9.15-jdk11.0.30-noble",
"maven_tag": "3.9.15-jdk11.0.32.1-noble",
"is_latest": false
},
{
"name": "node26-jdk11",
"node_version": "26.12.1",
"node_major": "26",
"jdk_version": "11",
"maven_tag": "3.9.15-jdk11.0.30-noble",
"maven_tag": "3.9.15-jdk11.0.32.1-noble",
"is_latest": false
},
{
"name": "node22-jdk17",
"node_version": "22.23.4",
"node_major": "22",
"jdk_version": "17",
"maven_tag": "3.9.15-jdk17.0.18-noble",
"maven_tag": "3.9.15-jdk17.0.20.1-noble",
"is_latest": false
},
{
"name": "node24-jdk17",
"node_version": "24.22.1",
"node_major": "24",
"jdk_version": "17",
"maven_tag": "3.9.15-jdk17.0.18-noble",
"maven_tag": "3.9.15-jdk17.0.20.1-noble",
"is_latest": false
},
{
"name": "node26-jdk17",
"node_version": "26.12.1",
"node_major": "26",
"jdk_version": "17",
"maven_tag": "3.9.15-jdk17.0.18-noble",
"maven_tag": "3.9.15-jdk17.0.20.1-noble",
"is_latest": false
},
{
"name": "node22-jdk21",
"node_version": "22.23.4",
"node_major": "22",
"jdk_version": "21",
"maven_tag": "3.9.15-jdk21.0.10-noble",
"maven_tag": "3.9.15-jdk21.0.12.1-noble",
"is_latest": true
},
{
"name": "node24-jdk21",
"node_version": "24.22.1",
"node_major": "24",
"jdk_version": "21",
"maven_tag": "3.9.15-jdk21.0.10-noble",
"maven_tag": "3.9.15-jdk21.0.12.1-noble",
"is_latest": false
},
{
"name": "node26-jdk21",
"node_version": "26.12.1",
"node_major": "26",
"jdk_version": "21",
"maven_tag": "3.9.15-jdk21.0.10-noble",
"maven_tag": "3.9.15-jdk21.0.12.1-noble",
"is_latest": false
},
{
"name": "node22-jdk25",
"node_version": "22.23.4",
"node_major": "22",
"jdk_version": "25",
"maven_tag": "3.9.15-jdk25.0.2-noble",
"maven_tag": "3.9.15-jdk25.0.4.1-noble",
"is_latest": false
},
{
"name": "node24-jdk25",
"node_version": "24.22.1",
"node_major": "24",
"jdk_version": "25",
"maven_tag": "3.9.15-jdk25.0.2-noble",
"maven_tag": "3.9.15-jdk25.0.4.1-noble",
"is_latest": false
},
{
"name": "node26-jdk25",
"node_version": "26.12.1",
"node_major": "26",
"jdk_version": "25",
"maven_tag": "3.9.15-jdk25.0.2-noble",
"maven_tag": "3.9.15-jdk25.0.4.1-noble",
"is_latest": false
}
],
Expand Down
Loading