Skip to content

Support LendingProtocolV1_1 #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cybele-ripple wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Support LendingProtocolV1_1 #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
251803e
Add support for upcoming Single Asset Vault deposit-blocking flags/fi…
cybele-ripple Sep 11, 2026
502ca19
Add closed-ended vault fields and VaultWithdraw credentials
cybele-ripple Sep 25, 2026
f44478d
Merge remote-tracking branch 'origin/main' into single-asset-vault-up…
cybele-ripple Oct 13, 2026
56307c4
Merge remote-tracking branch 'origin/single-asset-vault-updates' into…
cybele-ripple Oct 13, 2026
e1592dd
Fix Prettier formatting in VaultCreate/VaultWithdraw Simple views
cybele-ripple Oct 13, 2026
a85578a
Use real xrpl types for VaultKind/SubscriptionDate/RedemptionDate/Mem…
cybele-ripple Oct 15, 2026
e285658
Merge remote-tracking branch 'origin/main' into single-asset-vault-up…
cybele-ripple Oct 15, 2026
0049e74
fix: address PR review comments on vault flags, credential formatting
cybele-ripple Oct 19, 2026
67076a1
fix: address remaining PR review comments
cybele-ripple Oct 29, 2026
b3265cd
Merge remote-tracking branch 'origin/main' into single-asset-vault-up…
cybele-ripple Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions public/locales/ca-CA/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,9 @@
"assets_maximum": null,
"mptoken_metadata": null,
"withdrawal_policy": null,
"vault_kind": null,
"subscription_date": null,
"redemption_date": null,
"account_creates_vault": null,
"vault_id": null,
"single_asset_vault": null,
Expand Down Expand Up @@ -674,6 +677,8 @@
"account_clawbacks_from_vault": null,
"account_clawbacks_from_vault_amount_omitted": null,
"account_deletes_vault": null,
"vault_delete_memo_data": null,
"memo_data": null,
"vault_create_table_detail": null,
"withdraws": null,
"deletes": null,
Expand Down Expand Up @@ -840,6 +845,8 @@
"available_to_borrow": null,
"not_available": null,
"first_come_first_served": null,
"open_ended": null,
"closed_ended": null,
"loans": null,
"loan_broker": null,
"total_debt": null,
Expand Down
7 changes: 7 additions & 0 deletions public/locales/en-US/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@
"assets_maximum": "Assets Maximum",
"mptoken_metadata": "MPToken Metadata",
"withdrawal_policy": "Withdrawal Policy",
"vault_kind": "Vault Kind",

@pdp2121 pdp2121 Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add translation (placeholder with null values) for other languages

@cybele-ripple cybele-ripple Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added null placeholders for vault_kind, subscription_date, redemption_date, vault_delete_memo_data, memo_data, open_ended, and closed_ended across ca-CA, es-ES, fr-FR, ja-JP, ko-KR, and my-MM in the most recent commit

"subscription_date": "Subscription Date",
"redemption_date": "Redemption Date",
"account_creates_vault": "<Account/> created a vault for <Asset/>",
"vault_id": "Vault ID",
"single_asset_vault": "Single Asset Vault",
Expand Down Expand Up @@ -675,6 +678,8 @@
"account_clawbacks_from_vault": "<Account/> clawbacks<Amount/> from <Holder/>",
"account_clawbacks_from_vault_amount_omitted": "<Account/> clawbacks all remaining funds from <Holder/>",
"account_deletes_vault": "<Account/> deleted a vault with ID <VaultID/>",
"vault_delete_memo_data": "It sets the Vault deletion MemoData to <MemoData/>",
"memo_data": "Memo Data",
"vault_create_table_detail": "vault for <Asset/>",
"withdraws": "withdraws",
"deletes": "deletes",
Expand Down Expand Up @@ -845,6 +850,8 @@
"available_to_borrow": "Available to Borrow",
"not_available": "Not available",
"first_come_first_served": "First Come First Served",
"open_ended": "Open Ended",
"closed_ended": "Closed Ended",
"loans": "Loans",
"loan_broker": "Loan Broker",
"total_debt": "Total Debt",
Expand Down
7 changes: 7 additions & 0 deletions public/locales/es-ES/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@
"assets_maximum": null,
"mptoken_metadata": null,
"withdrawal_policy": null,
"vault_kind": null,
"subscription_date": null,
"redemption_date": null,
"account_creates_vault": null,
"vault_id": null,
"single_asset_vault": null,
Expand Down Expand Up @@ -675,6 +678,8 @@
"account_clawbacks_from_vault": null,
"account_clawbacks_from_vault_amount_omitted": null,
"account_deletes_vault": null,
"vault_delete_memo_data": null,
"memo_data": null,
"vault_create_table_detail": null,
"withdraws": null,
"deletes": null,
Expand Down Expand Up @@ -841,6 +846,8 @@
"available_to_borrow": null,
"not_available": null,
"first_come_first_served": null,
"open_ended": null,
"closed_ended": null,
"loans": null,
"loan_broker": null,
"total_debt": null,
Expand Down
7 changes: 7 additions & 0 deletions public/locales/fr-FR/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@
"assets_maximum": null,
"mptoken_metadata": null,
"withdrawal_policy": null,
"vault_kind": null,
"subscription_date": null,
"redemption_date": null,
"account_creates_vault": null,
"vault_id": null,
"single_asset_vault": null,
Expand Down Expand Up @@ -675,6 +678,8 @@
"account_clawbacks_from_vault": null,
"account_clawbacks_from_vault_amount_omitted": null,
"account_deletes_vault": null,
"vault_delete_memo_data": null,
"memo_data": null,
"vault_create_table_detail": null,
"withdraws": null,
"deletes": null,
Expand Down Expand Up @@ -841,6 +846,8 @@
"available_to_borrow": null,
"not_available": null,
"first_come_first_served": null,
"open_ended": null,
"closed_ended": null,
"loans": null,
"loan_broker": null,
"total_debt": null,
Expand Down
7 changes: 7 additions & 0 deletions public/locales/ja-JP/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@
"assets_maximum": null,
"mptoken_metadata": null,
"withdrawal_policy": null,
"vault_kind": null,
"subscription_date": null,
"redemption_date": null,
"account_creates_vault": null,
"vault_id": null,
"single_asset_vault": null,
Expand Down Expand Up @@ -675,6 +678,8 @@
"account_clawbacks_from_vault": null,
"account_clawbacks_from_vault_amount_omitted": null,
"account_deletes_vault": null,
"vault_delete_memo_data": null,
"memo_data": null,
"vault_create_table_detail": null,
"withdraws": null,
"deletes": null,
Expand Down Expand Up @@ -841,6 +846,8 @@
"available_to_borrow": null,
"not_available": null,
"first_come_first_served": null,
"open_ended": null,
"closed_ended": null,
"loans": null,
"loan_broker": null,
"total_debt": null,
Expand Down
7 changes: 7 additions & 0 deletions public/locales/ko-KR/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@
"assets_maximum": null,
"mptoken_metadata": null,
"withdrawal_policy": null,
"vault_kind": null,
"subscription_date": null,
"redemption_date": null,
"account_creates_vault": null,
"vault_id": null,
"single_asset_vault": null,
Expand Down Expand Up @@ -675,6 +678,8 @@
"account_clawbacks_from_vault": null,
"account_clawbacks_from_vault_amount_omitted": null,
"account_deletes_vault": null,
"vault_delete_memo_data": null,
"memo_data": null,
"vault_create_table_detail": null,
"withdraws": null,
"deletes": null,
Expand Down Expand Up @@ -841,6 +846,8 @@
"available_to_borrow": null,
"not_available": null,
"first_come_first_served": null,
"open_ended": null,
"closed_ended": null,
"loans": null,
"loan_broker": null,
"total_debt": null,
Expand Down
7 changes: 7 additions & 0 deletions public/locales/my-MM/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,9 @@
"assets_maximum": null,
"mptoken_metadata": null,
"withdrawal_policy": null,
"vault_kind": null,
"subscription_date": null,
"redemption_date": null,
"account_creates_vault": null,
"vault_id": null,
"single_asset_vault": null,
Expand Down Expand Up @@ -675,6 +678,8 @@
"account_clawbacks_from_vault": null,
"account_clawbacks_from_vault_amount_omitted": null,
"account_deletes_vault": null,
"vault_delete_memo_data": null,
"memo_data": null,
"vault_create_table_detail": null,
"withdraws": null,
"deletes": null,
Expand Down Expand Up @@ -841,6 +846,8 @@
"available_to_borrow": null,
"not_available": null,
"first_come_first_served": null,
"open_ended": null,
"closed_ended": null,
"loans": null,
"loan_broker": null,
"total_debt": null,
Expand Down
4 changes: 3 additions & 1 deletion src/containers/Transactions/simpleTab.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ $subdued-color: $black-40;
&.condition,
&.fulfillment,
&.tx,
&.channel {
&.channel,
&.vault-id,
&.credential-id {
width: calc(100% - 120px);
color: $subdued-color;
font-size: 14px;
Expand Down
54 changes: 45 additions & 9 deletions src/containers/Vault/VaultHeader/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@ import SocketContext from '../../shared/SocketContext'
import { getMPTIssuance } from '../../../rippled/lib/rippled'
import { parseVaultWebsite } from '../utils'
import {
shortenVaultID,
shortenAccount,
getCurrencySymbol,
isCurrencyExoticSymbol,
localizeDate,
} from '../../shared/utils'
import './styles.scss'
import { useAnalytics } from '../../shared/analytics'
Expand All @@ -23,6 +22,10 @@ import { convertHexToString } from '../../../rippled/lib/utils'
import { Metadata } from '../../Token/MPT/Header/Metadata'
import Currency from '../../shared/components/Currency'
import { parseMPTokenMetadata } from '../../shared/mptUtils'
import { VAULT_KINDS } from '../../shared/vaultUtils'
import { convertRippleDate } from '../../../rippled/lib/convertRippleDate'
import { DATE_OPTIONS } from '../../shared/transactionUtils'
import { useLanguage } from '../../shared/hooks'

interface VaultData {
Owner?: string
Expand All @@ -41,6 +44,9 @@ interface VaultData {
WithdrawalPolicy?: number
Data?: string
ShareMPTID?: string
VaultKind?: number
SubscriptionDate?: number
RedemptionDate?: number
}

interface Props {
Expand All @@ -61,6 +67,7 @@ const WITHDRAWAL_POLICIES: { [key: number]: string } = {

export const VaultHeader = ({ data, vaultId, displayCurrency }: Props) => {
const { t } = useTranslation()
const language = useLanguage()
const { trackException } = useAnalytics()
const rippledSocket = useContext(SocketContext)
const { rate: tokenToUsdRate } = useTokenToUSDRate(
Expand All @@ -80,6 +87,9 @@ export const VaultHeader = ({ data, vaultId, displayCurrency }: Props) => {
WithdrawalPolicy: withdrawalPolicy,
Data: vaultDataRaw,
ShareMPTID: vaultShareMptId,
VaultKind: vaultKind,
SubscriptionDate: subscriptionDate,
RedemptionDate: redemptionDate,
} = data

// Converts amount to USD if displayCurrency is 'USD', otherwise returns as-is
Expand Down Expand Up @@ -158,6 +168,19 @@ export const VaultHeader = ({ data, vaultId, displayCurrency }: Props) => {
return t(policyKey as 'first_come_first_served')
}

const getVaultKindText = () => {
if (vaultKind === undefined) return '-'
const kindKey = VAULT_KINDS[vaultKind]
if (!kindKey) return String(vaultKind)
// Use type assertion for dynamic translation keys
return t(kindKey as 'open_ended')
}

const formatVaultDate = (date: number) =>
`${localizeDate(new Date(convertRippleDate(date)), language, DATE_OPTIONS)} ${
DATE_OPTIONS.timeZone
}`

const renderMPTSharesLink = () => {
if (!vaultShareMptId) return '-'
return (
Expand Down Expand Up @@ -185,20 +208,15 @@ export const VaultHeader = ({ data, vaultId, displayCurrency }: Props) => {
value={
<CopyableText
text={vaultId}
displayText={`${shortenVaultID(vaultId)}`}
displayText={vaultId}
showCopyIcon
/>
}
/>
{owner && (
<TokenTableRow
label={t('owner')}
value={
<Account
account={owner}
displayText={`${shortenAccount(owner)}`}
/>
}
value={<Account account={owner} displayText={owner} />}
/>
)}
<TokenTableRow
Expand Down Expand Up @@ -262,6 +280,24 @@ export const VaultHeader = ({ data, vaultId, displayCurrency }: Props) => {
label={t('withdrawal_policy')}
value={getWithdrawalPolicyText()}
/>
{vaultKind !== undefined && (
<TokenTableRow
label={t('vault_kind')}
value={getVaultKindText()}
/>
)}
{subscriptionDate !== undefined && (
<TokenTableRow
label={t('subscription_date')}
value={formatVaultDate(subscriptionDate)}
/>
)}
{redemptionDate !== undefined && (
<TokenTableRow
label={t('redemption_date')}
value={formatVaultDate(redemptionDate)}
/>
)}
</tbody>
</table>
</div>
Expand Down
12 changes: 12 additions & 0 deletions src/containers/Vault/VaultHeader/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,19 @@
flex: 1;

.token-table {
width: 100%;
margin-top: 0;
table-layout: fixed;

// Values like Vault ID and Owner are long identifiers; let them use the
// full remaining width of the row instead of the shared table's fixed
// 230px column, wrapping only if the viewport is too narrow to fit
// them on one line.
.col2 {
display: block;
width: auto;
max-width: 100%;
}
}
}
}
Expand Down
Loading
Loading