Repository navigation
fix(backend): enforce dead letter consistency rule for delivery ID an… - #1430
Merged
github-actions[bot] merged 1 commit intoOct 25, 2026
Conversation
…d failure reason (SSB-2026-158)
|
@ugoocreates-pixel is attempting to deploy a commit to the ritik4ever's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces the consistency rule for webhook dead letters across handler responses, worker transitions, operator requeue workflows, and monitoring documentation as defined in SSB-2026-158.
Key Changes
Committed State Reflection & Delivery ID Consistency:
backend/src/services/webhook.ts,requeueDeadLettercaptures the newly generated delivery ID from SQLite'slastInsertRowidupon successfully committing the restored delivery, emitting structured outcome signals withdeliveryId.backend/src/services/webhookWorker.ts, dead-letter storage transition executes atomically within a singledb.transaction(...), preserving the originaldeliveryIdand ensuring the terminalfailureReasonmatches between stored dead letters and structured outcome logs.No Claimed State Changes on Failure:
falsewithout claiming a state change or mutating stored records.Tests & Documentation:
backend/src/services/webhook.test.tsandbackend/src/services/webhookWorker.test.tsverifying delivery ID retention, consistent failure reasons, and error boundary safety.docs/webhook-monitoring.md.Project area: backend · Batch ID: SSB-2026-158
Closes #1101