Drop redundant .to_s inside string interpolation#300
Merged
yahonda merged 1 commit intoMay 13, 2026
Conversation
In `CallableStatement#bind_param_index` the leading-colon normalization
wrote `":#{key.to_s}"`. String interpolation already invokes `to_s`
on the embedded expression, so the explicit call is redundant.
The `key.to_s =~ /^:/` on the right-hand side is intentionally kept;
that one is outside the interpolation and ensures the regex match
receives a String regardless of whether `key` is a Symbol or String.
No behavior change. Full suite is green (468 examples, 0 failures,
1 pre-existing pending).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
CallableStatement#bind_param_indexthe leading-colon normalization wrote:Ruby's string interpolation already calls
to_son the embedded expression, so the explicit.to_sinside"#{...}"is redundant.The
key.to_s =~ /^:/on the right-hand side is intentionally kept — it is outside the interpolation and exists to ensure the regex match receives a String regardless of whetherkeyarrives as a Symbol or String. Out of scope here.Diff stat:
lib/plsql/jdbc_connection.rb | 2 +-(1 line modified).Test plan
bundle exec rspec— 468 examples, 0 failures, 1 pre-existing pending🤖 Generated with Claude Code