Repository navigation
fix: complete the example documentation for real world usage - #1
Merged
Merged
Conversation
bougyman
commented
Oct 14, 2026
bougyman
commented
Member
- docs: show pg_reaper alongside connection_validator
- fix: keep development files out of the packaged gem
Document how the two extensions divide the work: pg_reaper replaces connections older than connection_max_lifetime at checkout, and connection_validator replaces connections that fail validation after sitting idle. For a pgdog rollout pg_reaper alone is enough, and the validator covers deaths unrelated to rollouts. - Add an "Idle connections" section to the Readme with a combined example - State the limits: no background closing, and checked out connections are never interrupted - Test both extensions together in each load order
The gem shipped release-please config, .rubocop.yml, .version.txt and the Rakefile. Exclude them from the gemspec file list so the gem contains only the license, Readme, docs and lib. - Drop the stale sequel/ exclude from .rubocop.yml
There was a problem hiding this comment.
🟡 Changes recommended
The operational guidance needs corrected rollout safety conditions and validation timeout semantics.
2 open findings
What changed in this PR
Expands practical usage guidance for pg_reaper and excludes additional development files from the packaged gem.
Changes:
- Documents use with
connection_validatorand adds compatibility tests for both load orders. - Refines gem packaging exclusions and lint scope.
| File | Description |
|---|---|
| test/sequel/test_pg_reaper.rb | Tests both extension load orders and replacement scenarios. |
| sequel-pg_reaper.gemspec | Excludes additional development files from packaging. |
| Readme.adoc | Expands connection lifecycle guidance and examples. |
| .rubocop.yml | Removes the sequel/**/* lint exclusion. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Address PR review feedback on the Readme. - Make the pgdog rollout guarantee conditional on a shutdown grace longer than the lifetime and on new connections avoiding a terminating pod - Describe connection_validation_timeout as an idle threshold, not a detection deadline
KBerryPP
approved these changes
Oct 14, 2026
OpenSourceAlchemist
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.