Repository navigation
add priority_queue wrapper - #56
Anshumancanrock wants to merge 4 commits into
Conversation
cf04ff3 to
cc4a85e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yes, 6 commits were made using claude after clearing my previous commits as they were messed up a bit. Going forward, I’ll make commits by hand to prevent this from happening again.
Thanks for mentioning this clearly. I’m well aware of AI policies and have used AI to understand some concepts, resolve errors, and review code. During reviews, AI made auto edits to parts of the code that were unrelated to the PR which i later reverted.
AGENTS file instuctions were not ignored initially. But when i was debugging test failures, ai auto fixed some code to resolve errors. |
This comment was marked as resolved.
This comment was marked as resolved.
cc4a85e to
457ea94
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
teor2345
left a comment
There was a problem hiding this comment.
Please make these changes and then comment so I know to do another review.
| } | ||
|
|
||
| overload! { | ||
| impl StdPriorityQueue { |
There was a problem hiding this comment.
I see 10 non-allocator constructors, but there are only 5 implemented here.
Please do this step again:
Check that you have implemented all the overloads for each method name, or documented why you can't
https://en.cppreference.com/cpp/container/priority_queue/priority_queue
|
|
||
| overload! { | ||
| impl StdPriorityQueue { | ||
| pub fn emplace(&mut self) { |
There was a problem hiding this comment.
Emplace can forward to any item constructor overloads. Is there anything different about using emplace that could make constructor overloads incompatible?
For example, does the extra self argument matter?
Or is there an element type and constructor that could conflict with the other emplace overloads?
Please document the item types where this could be a problem, or document why it isn't a problem for any item types.
|
Hi @teor2345, I've implemented the missing non-allocator constructors and documented emplace overload limitations. Please take a look when you get a chance. |
5341c24 to
d57efe0
Compare
|
Hi @teor2345 I’ve updated the docs to explain the Could you please take a look when you get a chance? |
Add priority queue wrappers using the
overload!macroCloses #47
Limitationsdoc sectionErgonomicsdoc sectionIncompatibilitiesdoc sectionWorkaroundsdoc sectionInexpressible Overloadsdoc sectionAI disclosure: Claude helped me with syntax, conceptual solution and debug build failures.