Skip to content

Enable trtx by default and load TensorRT from pip package if installed - #22

Draft
theHamsta wants to merge 3 commits into
rustnn:mainfrom
theHamsta:trtx-default
Draft

theHamsta wants to merge 3 commits into
rustnn:mainfrom
theHamsta:trtx-default

Conversation

@theHamsta

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Cargo.toml
pyo3 = { version = "0.28", features = ["extension-module"] }
bytemuck = "1.14"
rustnn = { git = "https://github.com/rustnn/rustnn", branch = "main" }
rustnn = { git = "https://github.com/theHamsta/rustnn", branch = "bring-dynamically_load_tensorrt-back" }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on rustnn/rustnn#280 (therefore git dep until merged)

Err(err) if err.matches(py, &metadata.getattr("PackageNotFoundError")?)? => return Ok(()),
Err(err) => return Err(err),
};
if version != "1.6.1.120" {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can get this versions automatically if we reexport the version methods from trtx_sys in trtx and rustnn rustnn/trtx-rs#146

Comment thread Cargo.toml

[features]
default = ["onnx-runtime", "dynamic-inputs"]
default = ["onnx-runtime", "trtx-runtime", "dynamic-inputs"]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counter argument against enabling by default is that trtx requires libclang for building.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant