Repository navigation
feat: additional builder API features for torch2webnn - #30
Merged
Merged
Conversation
theHamsta
commented
Nov 6, 2026
| self.inner_mut()? | ||
| .rustnn_webnn_text_for_outputs(&outputs) | ||
| .ok_or_else(|| PyValueError::new_err("Unable to serialize graph outputs")) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
those could also use pythonic short names instead of the rustnn_XXX from RustNN
theHamsta
commented
Nov 6, 2026
| pub(crate) handle: rustnn::mlcontext::MLOperand, | ||
| pub(crate) builder_id: u64, | ||
| pub(crate) shape: Vec<u64>, | ||
| pub(crate) data_type: String, |
Contributor
Author
There was a problem hiding this comment.
we could avoid copying state (shape, data_type) if we used the same API as RustNN that takes builder as arg. This API is a bit more pythonic.
theHamsta
force-pushed
the
new_uncompiled
branch
3 times, most recently
from
November 6, 2026 17:24
9f0b8f6 to
ce03ca7
Compare
theHamsta
force-pushed
the
new_uncompiled
branch
from
November 6, 2026 17:39
ce03ca7 to
9880f5b
Compare
mtavenrath
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APIs are used at rustnn/torch2webnn#3
On top of #29