Repository navigation
Conversation
Only the webnn-graph binary uses clap, but it was an unconditional dependency, so library consumers compiled it. Add a default `cli` feature enabling clap and gate the binary on it with `required-features`. Default builds are unchanged; `--no-default-features` now builds the library without clap.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the
webnn-graphbinary usesclap, but it was an unconditional dependency, so library consumers have to compile it.clifeature enablingclap; the binary is gated on it withrequired-features.--no-default-featuresbuilds the library withoutclap.Validation (rustc 1.97.0):
cargo fmt --check,cargo clippy --all-targets -- -D warningswith and without--no-default-features,cargo testwith and without--no-default-features,cargo build(binary still produced).cargo tree --no-default-features -i clapfinds noclap.Companion to rustnn/rustnn#328, which does the same for rustnn.