Repository navigation
Run the textsearch app's tests in CI - #62
Merged
Merged
Conversation
apps/textsearch is its own project, and julia-runtest tests only the package at the root, so no CI job ran the app's 279 tests: #58 and #59 went green on checks that covered none of their changes. A new app-test job resolves the app fresh (no Manifest is committed, as on a user's machine) and runs Pkg.test() on Ubuntu and Windows, with GITHUB_TOKEN for the release listings its tests make. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
write_fit_config substituted raw paths into TOML basic strings, where a Windows path's backslashes start escapes (\U...) and the parser fails with "invalid unicode scalar". Every fit test failed on Windows, and the tests built on their profiles with them. The app itself writes no paths into TOML; only the test helper did. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apps/textsearchis its own project ([sources] TextSearch = {path = "../.."}), andjulia-runtestonly tests the package at the root. So no CI job ran the app's tests: #58 (lazy loading of CSV/Parquet2) and #59 (all the LSI handling in the CLI) went green on checks that covered none of their changes.Change
A new
app-testjob inci.yml, on Ubuntu and Windows, which runs:pkg"app develop apps/textsearch"does on a user's machine. That also catches a compat that stops resolving.GITHUB_TOKEN, since the app's tests list releases through the API (Send GITHUB_TOKEN to the GitHub API when listing a release #60).testjob.Verified
I ran that same command on a clean worktree with no Manifest: 279/279. Windows only gets tested with this PR's CI. The library's
file://tests already pass on Windows, but this is the first time the app's run there.🤖 Generated with Claude Code