Repository navigation
fix(deps): bump rustls to 0.23.46 for RUSTSEC-2026-0346..0349 - #127
Merged
Merged
Conversation
`cargo deny check` now reports four advisories against rustls 0.23.45: `Debug` impls for client session values expose TLS secrets (0346), buffered application data sent to the outer server after ECH rejection (0347), Brotli certificate decompression can allocate up to 1 GiB before authentication (0348), and an unauthenticated ServerHello can downgrade later connections to classical key exchange (0349). All are fixed in >= 0.23.46. Lockfile-only change (rustls 0.23.45 -> 0.23.46); no other crate version moves. Signed-off-by: al2wang <lightever131@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
weiddeng
approved these changes
Oct 15, 2026
weiddeng
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. This is a minimal lockfile-only rustls 0.23.45 → 0.23.46 update; the existing caret requirement admits the patch release, no other dependency entries move, and 0.23.46 is the patched version for RUSTSEC-2026-0346 through -0349. The full CI and required source gate pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo deny check(the first command in the Dependency and license policy step) now fails on currentmain(3e2896c). It reports four advisories againstrustls 0.23.45:Debugimpls for client session values expose TLS secretsThis PR is a lockfile-only bump to
0.23.46(cargo update -p rustls --precise 0.23.46). No other crate version moves.rustls 0.23.46has the same dependency requirements as0.23.45. Therustls = "0.23.45"requirement incrates/execution/Cargo.tomlis a caret requirement and already admits0.23.46, so it stays as is.Context: every PR whose plan selects the policy step currently fails on these advisories regardless of its own content. #100 hits them in run 38609470613 (linux job, "Dependency and license policy"), and that failure fails its required
source-gate. Landing this separately unblocks #100 without changing it.Validation (local, Rust 1.89, cargo-deny 0.20.2 / cargo-audit 0.22.2 / cargo-about 0.9.2 as pinned in CI):
cargo deny check advisories bans licenses sources:advisories ok, bans ok, licenses ok, sources ok, with no RUSTSEC findings. Control on the same advisory-db snapshot (caee11f):mainreports exactly RUSTSEC-2026-0346, 0347, 0348 and 0349 and nothing else; this branch reports none.cargo deny check,cargo about generate about.hbswith the serde/MIT checks,tests/test-supply-chain.sh): pass.cargo fmt --all -- --check: pass.cargo clippy --locked --workspace --all-targets -- -D warnings: pass.cargo test --locked --workspace: 848 passed, 0 failed (54 suites), including the sandbox tests.🤖 Generated with Claude Code