Skip to content

S3UTILS-238: regression test for crrExistingObjects with non-ASCII keys#391

Draft
tcarmet wants to merge 3 commits into
development/1.17from
bugfix/S3UTILS-238/crr-non-ascii-keys
Draft

S3UTILS-238: regression test for crrExistingObjects with non-ASCII keys#391
tcarmet wants to merge 3 commits into
development/1.17from
bugfix/S3UTILS-238/crr-non-ascii-keys

Conversation

@tcarmet
Copy link
Copy Markdown
Contributor

@tcarmet tcarmet commented May 19, 2026

Intent: why does this change exist?

S3C-11235 / RD-1751 reported that crrExistingObjects fails with SignatureDoesNotMatch (HTTP 403) for any object whose key contains non-ASCII characters such as Polish diacritics, blocking the customer from replicating ~131k existing objects. The underlying bug was fixed in @scality/cloudserverclient 1.0.8, which s3utils picked up in S3UTILS-232, but no automated test exercises the path. This change adds the regression test so any future encoding regression in the dependency stack is caught in CI.

References: S3UTILS-238 · S3C-11235 · RD-1751 · CLDSRVCLT-13 · S3UTILS-232

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 19, 2026

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 19, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-238 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.17.10

  • 1.18.0

Please check the Fix Version/s of S3UTILS-238, or the target
branch of this pull request.

@claude
Copy link
Copy Markdown

claude Bot commented May 19, 2026

LGTM

Review by Claude Code

Lift the CRR setup and teardown helpers out of the
listObjectsByReplicationStatus functional test and into
tests/utils/S3Setup.js so they can be reused by other functional tests.
configureCrr gains an optional `storageClass` option for callers whose
flow matches by destination storage class.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.02%. Comparing base (8d43b21) to head (df67850).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           development/1.17     #391      +/-   ##
====================================================
+ Coverage             44.90%   45.02%   +0.12%     
====================================================
  Files                    88       88              
  Lines                  6454     6454              
  Branches               1350     1350              
====================================================
+ Hits                   2898     2906       +8     
+ Misses                 3510     3502       -8     
  Partials                 46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tcarmet added 2 commits May 19, 2026 15:49
…SCII keys

End-to-end regression test that drives ReplicationStatusUpdater against
the workbench cloudserver with objects whose keys contain Polish
diacritics (BŚ-test.txt, ąęóćśźżł-all-diacritics.txt, mixed/żółć/Łódź.dat)
and an ASCII control. Asserts no "error updating object" log was
emitted and that each source object's ReplicationStatus is updated to
PENDING.

Guards against future regressions in the path-encoding behavior of
the SigV4 signer used by @scality/cloudserverclient to talk to
cloudserver's /_/backbeat/metadata route - the failure mode reported
in S3C-11235 / RD-1751.
@tcarmet tcarmet force-pushed the bugfix/S3UTILS-238/crr-non-ascii-keys branch from 4647b55 to df67850 Compare May 19, 2026 22:53
@claude
Copy link
Copy Markdown

claude Bot commented May 19, 2026

LGTM

Review by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants