Skip to content

S3UTILS-235: Include logrotate in s3utils#392

Open
BourgoisMickael wants to merge 2 commits into
development/1.17from
improvement/S3UTILS-235-logrotate
Open

S3UTILS-235: Include logrotate in s3utils#392
BourgoisMickael wants to merge 2 commits into
development/1.17from
improvement/S3UTILS-235-logrotate

Conversation

@BourgoisMickael
Copy link
Copy Markdown

As object-repair will run through raft-dispatcher,
Log rotation will be handled by logrotate instead of supervisord

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 20, 2026

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@BourgoisMickael BourgoisMickael requested a review from a team May 20, 2026 17:05
@BourgoisMickael BourgoisMickael force-pushed the improvement/S3UTILS-235-logrotate branch from e0585e9 to 56f01b4 Compare May 20, 2026 17:06
@claude
Copy link
Copy Markdown

claude Bot commented May 20, 2026

LGTM

Review by Claude Code

As object-repair will run through raft-dispatcher,
Log rotation will be handled by logrotate instead of supervisord
@BourgoisMickael BourgoisMickael force-pushed the improvement/S3UTILS-235-logrotate branch from 56f01b4 to dbcfdab Compare May 20, 2026 17:09
@BourgoisMickael BourgoisMickael changed the base branch from development/1 to development/1.17 May 20, 2026 17:10
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 20, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@scality scality deleted a comment from bert-e May 20, 2026
@scality scality deleted a comment from bert-e May 20, 2026
@BourgoisMickael
Copy link
Copy Markdown
Author

/create_integration_branches

@claude
Copy link
Copy Markdown

claude Bot commented May 20, 2026

LGTM

Review by Claude Code

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 20, 2026

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.4
  • development/1.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 20, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.90%. Comparing base (8d43b21) to head (dbcfdab).

Additional details and impacted files
@@                Coverage Diff                @@
##           development/1.17     #392   +/-   ##
=================================================
  Coverage             44.90%   44.90%           
=================================================
  Files                    88       88           
  Lines                  6454     6454           
  Branches               1350     1350           
=================================================
  Hits                   2898     2898           
  Misses                 3510     3510           
  Partials                 46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BourgoisMickael BourgoisMickael requested a review from a team May 20, 2026 23:28
Comment thread package.json
{
"name": "s3utils",
"version": "1.17.9",
"version": "1.17.10",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already bumped to 1.17.10, sorry didn't know you would also need a bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants