(HOT Fix) Race condition on test

[scanoss-qg]

Fixed - Fixed flaky unit tests caused by concurrent SQLite :memory: connections

Summary by CodeRabbit

• Tests
  • Improved test database reliability by preventing connection pool race conditions in test scenarios.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3443b2e-05f2-4fde-8a2c-40f87a52f4e3

📥 Commits

Reviewing files that changed from the base of the PR and between a0c32b2 and 4d1f67b.

📒 Files selected for processing (1)

• pkg/models/common.go

---

📝 Walkthrough

Walkthrough

This PR adds a connection pool constraint to the SQLite in-memory test database setup. The LoadTestSQLData function now sets db.SetMaxOpenConns(1) to ensure all queries use the same database connection that contains loaded test fixtures, preventing race conditions where concurrent pooled connections might observe an empty database state.

Changes

SQLite Test Isolation Fix

Layer / File(s)	Summary
SQLite connection pool constraint in test setup pkg/models/common.go	LoadTestSQLData sets db.SetMaxOpenConns(1) with documentation explaining that pooled connections can race and observe an empty database state before fixtures load; limiting to 1 connection ensures all queries use the same connection and see the loaded data.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A database once played a race,
Where connections lost their place,
But one connection, calm and still,
Holds the fixtures on its sill,
No more chaos—tests are blessed!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title '(HOT Fix) Race condition on test' directly addresses the main change—fixing a race condition in tests by constraining SQLite connections.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch HotFix-FailingTest

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}