Skip to content

chore:SP-4320 replace error_code/error_message with info_code/info_me…#53

Merged
juliancoccia merged 1 commit into
mainfrom
chore/SP-4309-replace-error-code-by-info-code
Apr 16, 2026
Merged

chore:SP-4320 replace error_code/error_message with info_code/info_me…#53
juliancoccia merged 1 commit into
mainfrom
chore/SP-4309-replace-error-code-by-info-code

Conversation

@agustingroh

@agustingroh agustingroh commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

…ssage in dependency response

Summary by CodeRabbit

Version 0.14.0

  • Changed
    • Dependency API response field names updated from error_code/error_message to info_code/info_message
    • Component status code identifiers renamed: ComponentWithoutInfoNoInfo and VersionNotFoundRequirementNotMet
    • Multiple external dependency packages updated to latest versions including gRPC, PostgreSQL driver, SQLite, and component helper libraries

@agustingroh agustingroh requested a review from scanoss-qg April 16, 2026 18:01
@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@agustingroh has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 48 minutes and 51 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 48 minutes and 51 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9d6ab7d1-d42e-4fcb-a686-29d830c80fe6

📥 Commits

Reviewing files that changed from the base of the PR and between 29e28d5 and 5c4f581.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • CHANGELOG.md
  • go.mod
  • pkg/service/dependency_support.go
  • pkg/usecase/dependency.go
📝 Walkthrough

Walkthrough

This release (v0.14.0) renames dependency response fields from error-based to info-based terminology and updates component status codes (ComponentWithoutInfoNoInfo, VersionNotFoundRequirementNotMet). Dependency status handling logic is modified for URL lookup and version requirement validation, and upstream dependencies are updated to latest versions.

Changes

Cohort / File(s) Summary
Release Documentation & Dependencies
CHANGELOG.md, go.mod
CHANGELOG documents v0.14.0 with response field renames and status code changes; go.mod updates multiple dependencies including pq, go-component-helper, go-grpc-helper, papi, grpc, and sqlite to latest versions.
Dependency Service Layer
pkg/service/dependency_support.go
In convertDependencyOutput, non-success status codes now populate InfoCode/InfoMessage fields derived from StatusCode.String() instead of mapped ErrorCode/ErrorMessage.
Dependency Use Case Layer
pkg/usecase/dependency.go
Status code handling updated: URL lookup failures use NoInfo instead of ComponentWithoutInfo; missing license preserves upstream status if not Success; version mismatches use RequirementNotMet instead of VersionNotFound.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hop hop, the fields are renamed with care,
Info codes dance through the status air,
No longer lost in error's dark maze,
Dependencies glow with requirement's new praise!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: replacing error_code/error_message with info_code/info_message in dependency responses, which aligns with the PR objectives and the substantial code changes across multiple files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/SP-4309-replace-error-code-by-info-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

scanoss-qg
scanoss-qg previously approved these changes Apr 16, 2026

@scanoss-qg scanoss-qg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pkg/service/dependency_support.go`:
- Around line 91-93: The loop creates pointers to fields of the iteration
variable (dep.Status.Message) causing pointer aliasing; fix by copying the
message into a local variable before taking its address (e.g., create a local
msg := dep.Status.Message and set d.InfoMessage = &msg) so each d.InfoMessage
points to its own memory; keep the existing pattern for InfoCode (the code local
is fine).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8e3c1708-5505-429f-9626-93b3413eee8c

📥 Commits

Reviewing files that changed from the base of the PR and between cf4447c and 29e28d5.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • CHANGELOG.md
  • go.mod
  • pkg/service/dependency_support.go
  • pkg/usecase/dependency.go

Comment thread pkg/service/dependency_support.go Outdated
@juliancoccia juliancoccia merged commit f7d55c5 into main Apr 16, 2026
3 checks passed
@juliancoccia juliancoccia deleted the chore/SP-4309-replace-error-code-by-info-code branch April 16, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants