Fix: Disable OkHttp read timeout to prevent premature timeouts#43
Fix: Disable OkHttp read timeout to prevent premature timeouts#43jacek-kupczyk-wenovate wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesDisable read timeout on internal OkHttpClient
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8a7d2f8 to
055ddad
Compare
|
Hi @jacek-kupczyk-wenovate, thanks for this! I think the real issue is that OkHttp applies a default So 👍 on the default change. Could we drop the |
|
Thank you for the quick response. We don't actually need the read timeout to be configurable, so setting it to 0 should be sufficient. I agree that the --read-timeout CLI flag is an unnecessary knob in this case. I'll update my PR and add a PR message with some additional details. |
055ddad to
5db8466
Compare
5db8466 to
2ffba3f
Compare
|
@isasmendiagus I applied the changes as discussed. Please review PR again. |
This change disables OkHttp's default read timeout.
Previously, OkHttp applied a default 10 second read timeout, which caused requests to fail when processing larger payloads that the SCANOSS server could not complete within that time. By disabling the read timeout, the client no longer aborts these requests prematurely, allowing long-running responses to complete successfully.
Summary by CodeRabbit