Repository navigation
Add fifth Windows onboarding page - #905
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the fifth Windows onboarding page, “One window per line of work,” before backend selection so the tour matches the macOS page order without changing existing first-run persistence or backend behavior.
Changes
onboarding-seenmarkers and record the remaining visual/input evidence limits in the parity ledgerTest plan
RED: zig test src\WindowsOnboarding.zig --test-filter "five-page macOS contract" -> 1/1 executed; expected 5, found 4
GREEN: zig test src\WindowsOnboarding.zig --test-filter "five-page macOS contract" -> All 1 tests passed
REGRESSION: zig test src\WindowsOnboarding.zig -> All 16 tests passed
Additional focused result:
zig test src\WindowsOnboarding.zig --test-filter "workspace"-> All 3 tests passed.Not verified locally:
ScrubbedShellStartup.Live.Tests.ps1execution with built shell/daemon/CLI artifactsChecklist
git commit -s) per the DCOmake test)make check)