Skip to content

Add fifth Windows onboarding page - #905

Merged
coneilen merged 2 commits into
mainfrom
coneilen-windows-onboarding-fifth-page
Oct 21, 2026
Merged

coneilen merged 2 commits into
mainfrom
coneilen-windows-onboarding-fifth-page

Conversation

@coneilen

Copy link
Copy Markdown
Collaborator

Summary

Adds the fifth Windows onboarding page, “One window per line of work,” before backend selection so the tour matches the macOS page order without changing existing first-run persistence or backend behavior.

Changes

  • draw the workspace lesson with native GDI components and five progress indicators
  • move backend hit testing, keyboard focus and UIA actions from page 4 to page 5
  • extend the scrubbed first-run contract to advance through five pages
  • preserve existing onboarding-seen markers and record the remaining visual/input evidence limits in the parity ledger

Test plan

RED: zig test src\WindowsOnboarding.zig --test-filter "five-page macOS contract" -> 1/1 executed; expected 5, found 4
GREEN: zig test src\WindowsOnboarding.zig --test-filter "five-page macOS contract" -> All 1 tests passed
REGRESSION: zig test src\WindowsOnboarding.zig -> All 16 tests passed

Additional focused result: zig test src\WindowsOnboarding.zig --test-filter "workspace" -> All 3 tests passed.

Not verified locally:

  • native product build and C++ provider linkage
  • ScrubbedShellStartup.Live.Tests.ps1 execution with built shell/daemon/CLI artifacts
  • paired macOS/Windows screenshots or raster fidelity
  • physical keyboard operation or screen-reader behavior
  • broad Windows validation; exact-head CI owns broader regression

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test)
  • Code follows the existing style (make check)
  • I added the test/contract before the implementation and observed the intended RED failure

coneilen and others added 2 commits October 20, 2026 16:09
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen
coneilen marked this pull request as ready for review October 21, 2026 00:06
@coneilen
coneilen merged commit c468da8 into main Oct 21, 2026
26 checks passed
@coneilen
coneilen deleted the coneilen-windows-onboarding-fifth-page branch October 21, 2026 00:06
@coneilen coneilen mentioned this pull request Oct 21, 2026
3 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant