Repository navigation
Finish Windows Quick Chat canvas and workspace parity - #906
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
coneilen
marked this pull request as ready for review
October 21, 2026 00:44
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finish the remaining Windows Quick Chat source parity for #774: the empty Quick Chats canvas now matches the macOS composition, and a daemon-confirmed Quick Chat opens as its own agent-owned workspace instead of inheriting shell/previous-loop semantics.
Refs #774.
Changes
New Chataction, and independent top-right+ New Chataction on the Quick Chats canvas.Chat — Mon Dtitle and the configured default backend.Test plan
RED: & $env:GRAPHCODE_ZIG0152 test src\WorkspaceLayout.zig --test-filter "Quick Chat remaining parity" -> 1 executed, 0 passed, 1 failed because the existing chat-ID pane remained launches_agent=false
GREEN: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c $winghosttyLib -DUNICODE -D_UNICODE -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp "-I$include" $terminalVtLib --test-filter "Quick Chat remaining parity" -> 9 executed, 9 passed, 0 failed
REGRESSION: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c $winghosttyLib -DUNICODE -D_UNICODE -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp "-I$include" $terminalVtLib --test-filter "Quick Chat parity" -> 6 executed, 6 passed, 0 failed
Additional focused evidence:
WorkspaceLayout.zig --test-filter "ensureAgentFirst": 1 executed, 1 passed.GraphCanvas.zig --test-filter "Quick Chat remaining parity": 1 executed, 1 passed.TerminalSurface.zig --test-filter "Quick Chat remaining parity"with the pinned Winghostty and terminal VT libraries: 2 executed, 2 passed.6286560d0aa3103e068b2b7afa81eac373d870c9produced a nonempty host library from a clean provider worktree. The terminal VT preparation produced a nonemptyghostty-vt-static.lib.Evidence limits:
Checklist
git commit -s) per the DCOmake test)make check)