Skip to content

Drop rampUp from the sample loadtest profile - #626

Merged
masih merged 1 commit into
mainfrom
masih/1793131843-drop-seiload-rampup
Oct 27, 2026
Merged

masih merged 1 commit into
mainfrom
masih/1793131843-drop-seiload-rampup

Conversation

@masih

@masih masih commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

sei-load is removing its ramper and the rampUp setting. Profiles are decoded strictly, so once the sample's image moves to a build without it, the sample profile would fail at startup. This drops the key; it was false, the default, so the sample behaves the same on the current image.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@masih
masih marked this pull request as ready for review October 27, 2026 20:29
@cursor

cursor Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Sample Kubernetes manifest only; no runtime or application logic changes.

Overview
Removes the rampUp field from the sample profile.json embedded in loadtest-job.yaml so the genesis loadtest Job stays compatible with sei-load builds that drop the ramper and no longer accept that setting under strict profile decoding.

The value was false (the default), so behavior on current images is unchanged; this only avoids startup failures once the sample image is bumped to a sei-load version without rampUp.

Reviewed by Cursor Bugbot for commit f6b4e03. Bugbot is set up for automated code reviews on this repo. Configure here.

@masih
masih merged commit 4aabe71 into main Oct 27, 2026
17 checks passed

@seidroid seidroid Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the rampUp: false key from the sample sei-load profile in manifests/samples/jobs/loadtest-job.yaml, so the sample keeps starting once sei-load decodes profiles strictly and no longer has a ramper. The JSON is still valid after the edit and nothing else in the repository uses rampUp, so I'm approving; no merge ref was available, so I read the PR head tree instead, and the codex scout returned nothing in time, so no findings came from it.

seidroid review · decision approve · session b99bc097a4ee49f4a0696fe169a1fa82 · turn resp_claude_6a9181777835897fedae5b81c94186ad · item bbd1ef406cf15a8ab7c2939a9c9be957

Findings: 0 blocking | 0 non-blocking | 0 posted inline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant