Repository navigation
Drop rampUp from the sample loadtest profile - #626
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
PR SummaryLow Risk Overview The value was Reviewed by Cursor Bugbot for commit f6b4e03. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
This removes the rampUp: false key from the sample sei-load profile in manifests/samples/jobs/loadtest-job.yaml, so the sample keeps starting once sei-load decodes profiles strictly and no longer has a ramper. The JSON is still valid after the edit and nothing else in the repository uses rampUp, so I'm approving; no merge ref was available, so I read the PR head tree instead, and the codex scout returned nothing in time, so no findings came from it.
seidroid review · decision approve · session b99bc097a4ee49f4a0696fe169a1fa82 · turn resp_claude_6a9181777835897fedae5b81c94186ad · item bbd1ef406cf15a8ab7c2939a9c9be957
Findings: 0 blocking | 0 non-blocking | 0 posted inline
sei-load is removing its ramper and the
rampUpsetting. Profiles are decoded strictly, so once the sample's image moves to a build without it, the sample profile would fail at startup. This drops the key; it wasfalse, the default, so the sample behaves the same on the current image.