Repository navigation
Conversation
Cover empty reallocate, explicit non-owning setRawData, and the documented reallocate-then-append path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2375 +/- ##
==========================================
+ Coverage 82.85% 83.11% +0.25%
==========================================
Files 350 351 +1
Lines 68900 68723 -177
Branches 14255 14622 +367
==========================================
+ Hits 57089 57119 +30
+ Misses 10873 10658 -215
- Partials 938 946 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the added RawPacket buffer-handling tests.
No open issues 🎉
What changed in this PR
Adds focused Packet++Test coverage for RawPacket buffer handling, improving confidence in existing APIs without changing production behavior or adding capacity tracking.
Changes:
- Tests empty-buffer reallocation, explicit non-owning buffer replacement, and appending after reallocation.
- Registers all three tests under the
packet;rawpackettags and includes them in the build.
| File | Description |
|---|---|
| Tests/Packet++Test/Tests/RawPacketTests.cpp | Adds three buffer-handling tests. |
| Tests/Packet++Test/TestDefinition.h | Declares the new test cases. |
| Tests/Packet++Test/main.cpp | Registers the tests with filtering tags. |
| Tests/Packet++Test/CMakeLists.txt | Adds the test source to the build. |
Review effort: Balanced
|
Sigh... I love missclicking... |
There was a problem hiding this comment.
LGTM.
Fuzz CI faiures seem to be unrelated, since it complains about /tmp/not-out/tmp8hawj75b/FuzzTargetNg: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by /tmp/not-out/tmp8hawj75b/FuzzTargetNg)` which is not part of the PR changes?
Summary
Packet++Testcoverage forRawPacketbuffer handling.reallocateData, explicitsetRawDatawithtakeOwnership=false, and reallocate-then-appendData.RawPacket#1910 / Enhancements onRawPacketinfrastructure. #1888 (more confidence around RawPacket; this PR does not implement capacity tracking).Test plan
Packet++Test -t rawpacket