Skip to content

fix: avoid false successComment deprecation warning - #1316

Open
sean0407 wants to merge 1 commit into
semantic-release:masterfrom
sean0407:codex/semantic-release-github-1297-success-comment-warning
Open

sean0407 wants to merge 1 commit into
semantic-release:masterfrom
sean0407:codex/semantic-release-github-1297-success-comment-warning

Conversation

@sean0407

@sean0407 sean0407 commented Oct 19, 2026 •

Copy link
Copy Markdown

Summary

  • Emit the successComment deprecation warning only when successComment is explicitly false.
  • Keep the no-commit behavior that skips issue and pull request comments.

Evidence

  • Reproduction: run a release with an empty commits array and leave successComment unset. The combined skip condition is true, and the current implementation logs a deprecation warning for a value that was not configured.
  • Regression coverage verifies that the empty-commits case does not warn and that successComment: false still warns.
  • Changed files: lib/success.js, test/success.test.js.
  • Checks run: node --check lib/success.js, node --check test/success.test.js, and git diff --check passed.

Merge Danger

Low. The change only narrows when the deprecation warning is logged; comment skipping and all release behavior remain unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant