Repository navigation
Conversation
Signed-off-by: piguagua <shabipengqi@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use floor rather than round when converting a JavaScript Date to Unix seconds. At 500–999 milliseconds into a second, rounding advances the timestamp into the next second. Add boundary cases around the half-second point and immediately before the Unix epoch.
Related Issue(s)
#1105
Other information
The actual TypeScript utility passed direct Node assertions for all added time boundaries. The project Jest, formatting and lint commands still need to run.
Checklist