Repository navigation
The extras files are merged into the entries they patched; a test keeps them gone (refactor 3.5, D13) - #249
Merged
Conversation
sf624
added this pull request to stack #250
October 23, 2026 11:48
Contributor
|
Web preview: https://sf624.github.io/bash-explainer/pr/249/ (commit a3e130c) |
sf624
force-pushed
the
refactor/3.5e-extras
branch
from
October 23, 2026 12:02
58781ca to
0719704
Compare
…ps them gone (refactor 3.5, D13) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
sf624
force-pushed
the
refactor/3.5e-extras
branch
from
October 23, 2026 13:03
0719704 to
a3e130c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor step 3.5 (option parsing), layer 3 of 3. Stacked on #248.
Addresses: D13
applyExtras: each command's extra options and subcommands now sit in the entry of the file that defines the command. A name the main entry already defined kept the main entry's meaning, asmergeOptionsdid. A dump of every entry (options, values, texts, subcommands) is identical before and after, and so is the sample.sh dump. test/dictionary.test.ts fails if an extras file orapplyExtrascomes back;cmd()already throws on an option named twice in one entry. scripts/check-dict-manpages.ts walks every dict table.No CHANGELOG line: users see no change.
Checks:
npm test,extract-snippets --check, Node 24 coverage (every line and branch) pass.🤖 Generated with Claude Code