Skip to content

Support GitHub Apps - #306

Merged
Hayden-IO merged 1 commit into
sigstore:mainfrom
jku:support-apps
Oct 13, 2026
Merged

Hayden-IO merged 1 commit into
sigstore:mainfrom
jku:support-apps

Conversation

@jku

@jku jku commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

The named actor can now be user, group or an app. This covers:

  • PR bypass list
  • Dismissal restrictions
  • Push restrictions

If the app is named "my-app" then the item in the list needs to be "my-app[bot]":

  • Purpose of the postfix is to prevent users/apps from shadowing each others namespaces: user and group names cannot have "[]" in them
  • we could use an alternative syntax like "app:my-app" but I chose this one since it matches what ends up being visible in GitHub comments

The named actor can now be user, group or an app. This covers:
* PR bypass list
* Dismissal restrictions
* Push restrictions

If the app is named "my-app" then the item in the list needs to "my-app[bot]"
(similar to how it is shown by GitHub). This prevents users/apps from shadowing
each others namespaces: user names cannot have "[]" in them.

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku

jku commented Oct 12, 2026 •

Copy link
Copy Markdown
Member Author

If the app is named "my-app" then the item in the list needs to "my-app[bot]" (we could use an alternative syntax like "app:my-app" but I chose this one since it matches what ends up being visible in GitHub comments). This prevents users/apps from shadowing each others namespaces: user names cannot have "[]" in them.

This is the potentially problematic part here... but since this is just used sigstore/community I don't see a major risk: if we need to change this syntax later that's still fine

@Hayden-IO
Hayden-IO merged commit a1d2589 into sigstore:main Oct 13, 2026
3 checks passed
jku added a commit to jku/community that referenced this pull request Oct 13, 2026
This is a part of replacing the sigstore-bot tokens
with GitHub apps: once things are working, sigstore-bot
will be removed from the same lists

This requires sigstore/github-sync#306

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Hayden-IO pushed a commit to sigstore/community that referenced this pull request Oct 13, 2026
* root-signing repos: Add tuf-on-ci bots to bypass lists

This is a part of replacing the sigstore-bot tokens
with GitHub apps: once things are working, sigstore-bot
will be removed from the same lists

This requires sigstore/github-sync#306

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

* docs: Document GitHub App use

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

---------

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants