Skip to content

Delegated targets support - #1173

Open
loosebazooka wants to merge 1 commit into
mainfrom
tuf-delegated-targets
Open

loosebazooka wants to merge 1 commit into
mainfrom
tuf-delegated-targets

Conversation

@loosebazooka

@loosebazooka loosebazooka commented Feb 23, 2026 •

Copy link
Copy Markdown
Member
  • No support for succinct delegations
  • Removed eager download of all targets
    • SigstoreTufClient must now download the targets it wants explicitly
  • Rename update() to refresh() to match naming of other clients
  • Correctly handle url escaping in names

NOTE: this was produced with the help of AI coding tools

Summary

Release Note

Documentation

@loosebazooka
loosebazooka force-pushed the tuf-delegated-targets branch 6 times, most recently from 58d5ebf to cd71b05 Compare February 26, 2026 15:20
@loosebazooka
loosebazooka marked this pull request as ready for review February 27, 2026 16:52

@jku jku left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me:

  • I would have raised the question of "do you really want more code in sigstore-java" but if there are any plans of extracting the tuf part into a library, then I think this is valid as is it makes the implementation spec complete
  • I've read the code, left one note about reading local metadata
  • I would not trust my ability to verify this code by just reading (since I've overlooked so many bugs in the corresponding python implementation) but I am much more confident about the conformance testing: it really should cover a lot of potential mistakes in this area

@loosebazooka
loosebazooka force-pushed the tuf-delegated-targets branch from cd71b05 to 0a91cbb Compare March 10, 2026 15:42
@loosebazooka
loosebazooka requested a review from jku April 20, 2026 14:30
@loosebazooka
loosebazooka force-pushed the tuf-delegated-targets branch from 0a91cbb to bb1101a Compare October 23, 2026 22:09
- No support for succinct delegations
- Removed eager download of all targets
  - SigstoreTufClient must now download the targets it wants explicitly
- Rename updateMeta() to refresh() to match naming of other clients
  - downloadTarget() implicitly calls refresh() if not yet refreshed
- Correctly handle url escaping in names
- Delegated target meta is cached per session
- Enable passing delegation tests in tuf-cli xfails

Signed-off-by: Appu Goundan <appu@google.com>
@loosebazooka
loosebazooka force-pushed the tuf-delegated-targets branch from bb1101a to 26cbb11 Compare November 2, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants