Repository navigation
Conversation
Member
|
I would need some reasoning behind why this is required. What does this unlock for you? |
Replace the hardcoded --release 17 on compileTestJava with a build-parameters property (default 17), mirroring targetJavaVersion for main sources. Validate that the resolved test JDK is at least testTargetJavaVersion. Fixes sigstore#1276 Signed-off-by: B. Pagels-Minor <b@thewealthsalons.com>
b-pm
force-pushed
the
fix/1276-test-target-java-version
branch
from
October 30, 2026 18:45
8a1dc24 to
0e1499e
Compare
Author
|
I picked it partially because it was an open issue and I realized that this would be very helpful in supporting newer JDKs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1276
Summary
Adds a
testTargetJavaVersionbuild-parameters property (default17) so test bytecode--releaseis configurable the same waytargetJavaVersionis for main sources.build-logic/build-parameters: newtestTargetJavaVersion(default 17, mandatory)build-logic.java.gradle.kts:compileTestJavausesbuildParameters.testTargetJavaVersioninstead of a hardcoded17ToolchainProperties.kt: Gradle check thattestTargetJavaVersion >= 17and that the resolved test JDK is at least that valueDEVELOPMENT.md: example-PtestTargetJavaVersion=21Verify
AI disclosure
This PR was prepared with AI assistance (coding agent). I reviewed the change and can explain it. I will answer any maintainer questions myself.
DCO
I will add my Signed-off-by via
git commit --amend -s/git commit -safter opening; this commit intentionally has no agent-added DCO trailer per Sigstore AI_POLICY.md.