Repository navigation
fix: compute DSSE PAE from raw bytes - #1333
Merged
Merged
Conversation
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Member
|
Oh weird. Is there a conformance test for this? |
Collaborator
Author
|
@loosebazooka No, |
aaronlew02
marked this pull request as ready for review
November 2, 2026 23:44
loosebazooka
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the computation of the Pre-Authentication Encoding (PAE) for DSSE envelopes to correctly use raw bytes.
The DSSE Protocol requires each length in the PAE to be a byte count, and the body to be the raw payload bytes. Previously, we used UTF-16 code unit counts for the lengths, and we decoded the payload from UTF-8 and then re-encoded it.
Now, we correctly verify bundles with non-ASCII DSSE payloads, and other clients following the DSSE protocol can verify bundles that we sign. Bundles with non-ASCII payloads signed using
sigstore-javav2.0.0 to v2.4.0 do not follow the DSSE protocol, and they will no longer verify. Bundles with ASCII-only payloads are not affected.