Skip to content

Fix LT-22581: Crash clicking Values expansion button#973

Merged
jtmaxwell3 merged 2 commits into
mainfrom
LT-22581
Jul 1, 2026
Merged

Fix LT-22581: Crash clicking Values expansion button#973
jtmaxwell3 merged 2 commits into
mainfrom
LT-22581

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

This fixes https://jira.sil.org/browse/LT-22581. The code crashed because m_key wasn't initialized.


This change is Reviewable

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 39s ⏱️ +5s
4 299 tests +5  4 226 ✅ +5  73 💤 ±0  0 ❌ ±0 
4 308 runs  +5  4 235 ✅ +5  73 💤 ±0  0 ❌ ±0 

Results for commit 3487ca8. ± Comparison against base commit cf8d588.

♻️ This comment has been updated with latest results.

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).


Src/Common/Controls/DetailControls/DataTree.cs line 5305 at r1 (raw file):

			m_node = node;
			m_path = path;
			m_key = path.ToArray(); // This fixes LT-22581.

This seemed like too big of an oversight to have lived this long so I investigated a bit. There are multiple logic gates in the code which use a null key value as a sentinel. This will have behavior changes beyond the crash. I think a guard in the crash location might be better. You could even ask Claude to look for any other places where the key needs a guard.

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).

@jtmaxwell3 jtmaxwell3 merged commit 323a022 into main Jul 1, 2026
6 of 7 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22581 branch July 1, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants