Fix LT-22581: Crash clicking Values expansion button#973
Conversation
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).
Src/Common/Controls/DetailControls/DataTree.cs line 5305 at r1 (raw file):
m_node = node; m_path = path; m_key = path.ToArray(); // This fixes LT-22581.
This seemed like too big of an oversight to have lived this long so I investigated a bit. There are multiple logic gates in the code which use a null key value as a sentinel. This will have behavior changes beyond the crash. I think a guard in the crash location might be better. You could even ask Claude to look for any other places where the key needs a guard.
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).
This fixes https://jira.sil.org/browse/LT-22581. The code crashed because m_key wasn't initialized.
This change is