Conversation
Restoring a backup over a project that was open (and therefore file-locked) overwrote the project's data and then crashed. Fix it in two places: - RestoreCurrentProject now checks if the project is locked before doing anything destructive (overwriting files). - ExecuteWithAppsShutDown adds a narrow safety net that catches a LcmFileLockedException when reopening. This covering the small window where the project could get locked between the up-front check and the reopen. Any other StartupException is left to propagate so unexpected failures still generate a crash report. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jasonleenaylor
approved these changes
Jul 2, 2026
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mark-sil).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a backup over a project that was open (and therefore file-locked) overwrote the project's data and then crashed.
Fix it in two places:
RestoreCurrentProject now checks if the project is locked before doing anything destructive (overwriting files).
ExecuteWithAppsShutDown adds a narrow safety net that catches a LcmFileLockedException when reopening. This covering the small window where the project could get locked between the up-front check and the reopen. Any other StartupException is left to propagate so unexpected failures still generate a crash report.
This change is