Skip to content

TT-7481 refactor(burrito): standardize flavorType naming in burrito transformation#384

Closed
gtryus wants to merge 1 commit into
developfrom
TT-7481-burrito-name-conform
Closed

TT-7481 refactor(burrito): standardize flavorType naming in burrito transformation#384
gtryus wants to merge 1 commit into
developfrom
TT-7481-burrito-name-conform

Conversation

@gtryus

@gtryus gtryus commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
  • Updated the flavorType.name to 'scripture' across various components to ensure consistency in the burrito transformation process.
  • Adjusted related tests to reflect the new naming convention, enhancing clarity and maintainability.
  • Improved handling of legacy flavor names to accommodate existing data structures.
  • Add currentScope to the intellectualproperty custom burrito

This commit improves compliance with the custom burrito standard

…ation

- Updated the `flavorType.name` to 'scripture' across various components to ensure consistency in the burrito transformation process.
- Adjusted related tests to reflect the new naming convention, enhancing clarity and maintainability.
- Improved handling of legacy flavor names to accommodate existing data structures.
- Add currentScope to the intellectualproperty custom burrito

This commit improves compliance with the custom burrito standard
@gtryus gtryus changed the title refactor(burrito): standardize flavorType naming in burrito transformation TT-7381 refactor(burrito): standardize flavorType naming in burrito transformation Jul 1, 2026
@gtryus gtryus changed the title TT-7381 refactor(burrito): standardize flavorType naming in burrito transformation TT-7481 refactor(burrito): standardize flavorType naming in burrito transformation Jul 1, 2026
@gtryus gtryus marked this pull request as draft July 1, 2026 19:40
@gtryus gtryus requested review from Copilot and sarahentzel July 1, 2026 19:50
@gtryus gtryus marked this pull request as ready for review July 1, 2026 19:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes Scripture Burrito metadata so metadata.type.flavorType.name is consistently scripture, while custom burrito variants are expressed via metadata.type.flavorType.flavor.name (e.g., x-nav, x-apmdata, x-intellectualproperty, x-notes). It also extends the intellectual property burrito to include currentScope derived from the same project selection used for ApmData exports, and updates the migration importer to recognize legacy exports where custom flavors were stored in flavorType.name.

Changes:

  • Standardize burrito flavorType.name to scripture and move custom identifiers to flavorType.flavor.name in export hooks (audio, nav, ApmData, intellectual property).
  • Add currentScope population to the intellectual property burrito based on selected ApmData projects.
  • Update tests and the burrito→PTF migration script to support the new convention and legacy flavor naming.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/renderer/src/burrito/useCreateBurrito.ts Passes selected ApmData projects into intellectual property export so currentScope can be derived consistently.
src/renderer/src/burrito/useCreateBurrito.test.ts Updates test expectations/fixtures to reflect standardized scripture flavorType naming.
src/renderer/src/burrito/useBurritoNavigation.ts Sets flavorType.name = scripture and assigns custom nav flavor via flavor.name = x-nav.
src/renderer/src/burrito/useBurritoNavigation.test.ts Adapts tests for new flavor semantics and refactors module loading to dynamic import().
src/renderer/src/burrito/useBurritoIntellectualProperty.ts Adds currentScope merge (from selected projects) and standardizes flavor naming for intellectual property burrito.
src/renderer/src/burrito/useBurritoIntellectualProperty.test.ts Adds mocks/expectations for currentScope generation and standardized flavor naming.
src/renderer/src/burrito/useBurritoAudio.ts Keeps flavorType.name as scripture and uses flavor.name for custom exports like notes (x-notes).
src/renderer/src/burrito/useBurritoAudio.test.ts Updates assertions to match scripture + flavor.name convention for notes export.
src/renderer/src/burrito/useBurritoApmData.ts Populates currentScope via helper and standardizes ApmData flavor naming to scripture + x-apmdata.
src/renderer/src/burrito/useBurritoApmData.test.ts Updates expectations for standardized ApmData flavorType.name.
src/renderer/src/burrito/akuoBookToUsfm.ts Adds helpers to compute per-project and unioned currentScope entries for burrito exports.
migration/05-burrito-to-ptf.test.mjs Updates migration fixtures to the standardized scripture flavorType name.
migration/05-burrito-to-ptf.js Improves legacy handling by treating flavorType.name values starting with x- as legacy custom flavors.

@gtryus gtryus closed this Jul 1, 2026
@gtryus gtryus deleted the TT-7481-burrito-name-conform branch July 1, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants