TT-7191 feat(burrito): add Philippians publishing fixture and related functionality#385
Merged
Merged
Conversation
… functionality - Introduced `philippiansPublishingFixture.ts` to define the structure for Philippians publishing, including sections, passages, and media files. - Implemented functions to create sections and passages, enhancing the fixture's usability for testing. - Added tests for the Philippians publishing hierarchy, ensuring correct export behavior for notes and media files. - Updated `resolveBurritoExportFolder` to support chapter parsing from CHNUM references, improving folder resolution logic. This commit enhances the burrito export process by integrating a comprehensive fixture for Philippians, facilitating better organization and retrieval of publishing data.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Philippians-specific publishing fixtures and extends burrito export folder resolution to correctly derive chapter folders from CHNUM references (including CHNUM 2 space format), with tests covering the new hierarchy and export placement behavior.
Changes:
- Introduced a Philippians publishing fixture (sections, passages, mediafiles) to exercise burrito export behavior.
- Added
chnumChapterFromRef()and updated burrito export logic to parse chapter numbers from bothCHNUM|NandCHNUM Nformats. - Added/extended tests to validate note export placement (book-root vs chapter folders) and CHNUM parsing behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/burrito/useBurritoAudio.ts | Reuses centralized CHNUM chapter parsing helper when deriving section/passage chapter folders during export. |
| src/renderer/src/burrito/useBurritoAudio.test.ts | Adds Philippians note-export coverage using the new fixture and validates chapter-2 placement and book-root uniqueness. |
| src/renderer/src/burrito/resolveBurritoExportFolder.ts | Adds chnumChapterFromRef() and uses it in folder resolution; differentiates Book vs Alt Book scope refs. |
| src/renderer/src/burrito/resolveBurritoExportFolder.test.ts | New unit tests for CHNUM parsing and folder resolution (book rows + CHNUM space format). |
| src/renderer/src/burrito/philippiansPublishingFixture.ts | New Philippians publishing fixture builder and section selector used by tests. |
| phpNoteSections, | ||
| type PhilippiansPublishingFixture, | ||
| } from './philippiansPublishingFixture'; | ||
| import { isBookRootPath } from './jamesPublishingFixture'; |
sarahentzel
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
philippiansPublishingFixture.tsto define the structure for Philippians publishing, including sections, passages, and media files.resolveBurritoExportFolderto support chapter parsing from CHNUM references, improving folder resolution logic.This commit enhances the burrito export process by integrating a comprehensive fixture for Philippians, facilitating better organization and retrieval of publishing data.