TT-7306 feat(migration): add Luke chapter 1 transcription and audio handling for burrito transformation#386
Merged
Merged
Conversation
…andling for burrito transformation - Implemented functions to generate USFM text and audio files for Luke 1:1-14, enhancing the burrito-to-PTF import process. - Created metadata files for both text and audio ingredients, ensuring proper structure and MIME type handling. - Added tests to verify that verse tags and line breaks are preserved in the transcription, improving data integrity during transformation. - Introduced a temporary directory setup for testing, streamlining the process of writing and validating generated files. This commit expands the burrito transformation capabilities by integrating scripture text and audio, facilitating better content management. TT-7252 feat(burrito): add convertToMp3 functionality for navigation audio - Enhanced the `useBurritoNavigation` hook to support an optional `convertToMp3` parameter, allowing for the transcoding of non-MP3 audio files to MP3 format during navigation export. - Updated the `processMediaFile` function to handle audio conversion and deletion of original files when applicable. - Added tests to verify the correct behavior of audio conversion and retention of original formats based on the `convertToMp3` flag. - Integrated the `convertToMp3` option into the `useCreateBurrito` hook, ensuring it propagates through the burrito creation process. This commit improves audio handling in the burrito export process, providing flexibility in audio format management. refactor(burrito): improve dynamic imports and async handling in navigation tests - Updated `loadNavigationForApi` and `loadNavigationForJames` functions to use dynamic imports for better module isolation during tests. - Changed the function signatures to be asynchronous, ensuring proper loading of dependencies and maintaining a single React instance for hooks. - Refactored mock implementations to align with the new async structure, enhancing test reliability and clarity. This commit streamlines the testing process for the `useBurritoNavigation` hook, improving module loading and execution flow.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands burrito export/import coverage by (1) propagating an org-level convertToMp3 setting into navigation exports (so navigation audio can be transcoded to MP3), and (2) adding a migration fixture/test to ensure transcription USFM verse markers and line breaks survive the burrito → PTF transformation.
Changes:
- Pass
convertToMp3from org defaults throughuseCreateBurritointouseBurritoNavigation, and implement optional MP3 transcoding + correct output MIME typing in navigation ingredients. - Refactor
useBurritoNavigationtests to use dynamic imports (module isolation) and add coverage for conversion vs non-conversion behavior. - Add a Luke 1:1–14 transcription/audio burrito fixture and a migration test asserting verse tags (
\\v) and line breaks are preserved.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/burrito/useCreateBurrito.ts | Propagates org-level convertToMp3 into navigation export calls. |
| src/renderer/src/burrito/useCreateBurrito.test.ts | Adds assertions that convertToMp3 is forwarded to navigation export based on org defaults. |
| src/renderer/src/burrito/useBurritoNavigation.ts | Adds convertToMp3 option, transcodes non-MP3 navigation audio, and updates ingredient paths/MIME types accordingly. |
| src/renderer/src/burrito/useBurritoNavigation.test.ts | Uses dynamic imports for better isolation and adds tests for MP3 conversion and MIME/path updates. |
| migration/05-burrito-to-ptf.test.mjs | Adds Luke transcription/audio burrito fixture and a migration test validating verse markers + line breaks preservation. |
sarahentzel
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit expands the burrito transformation capabilities by integrating scripture text and audio, facilitating better content management.
TT-7252 feat(burrito): add convertToMp3 functionality for navigation audio
useBurritoNavigationhook to support an optionalconvertToMp3parameter, allowing for the transcoding of non-MP3 audio files to MP3 format during navigation export.processMediaFilefunction to handle audio conversion and deletion of original files when applicable.convertToMp3flag.convertToMp3option into theuseCreateBurritohook, ensuring it propagates through the burrito creation process.This commit improves audio handling in the burrito export process, providing flexibility in audio format management.
refactor(burrito): improve dynamic imports and async handling in navigation tests
loadNavigationForApiandloadNavigationForJamesfunctions to use dynamic imports for better module isolation during tests.This commit streamlines the testing process for the
useBurritoNavigationhook, improving module loading and execution flow.