Desktop clear cache hang#388
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a desktop startup/“clear cache” hang by ensuring the initial renderer paint does not block on IndexedDB migration/restore or fingerprint generation. It restructures startup so non-critical initialization happens after the React tree mounts.
Changes:
- Render the app immediately in
main.tsxwithout awaiting fingerprint or IndexedDB restore. - Add mount-time bootstrap components to restore IndexedDB backup and fetch the fingerprint after first paint.
- Add restore de-duplication and an IndexedDB “DB open” readiness check in the backup restore flow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/main.tsx | Stops awaiting fingerprint/backup restore before first render; renders immediately. |
| src/renderer/src/crud/RestoreBackupOnMount.tsx | New component to restore IndexedDB backup post-mount and update projectsLoaded. |
| src/renderer/src/crud/restoreBackup.ts | Memoizes restore calls and adds a readiness check for IndexedDB being open. |
| src/renderer/src/crud/BootstrapFingerprint.tsx | New component to load fingerprint post-mount and update global state. |
| src/renderer/src/auth/Root.tsx | Mounts the new bootstrap components early in the app tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.