Update actions to deploy to fcbh instance

[7dev7urandom]

Summary by CodeRabbit

• New Features

  • Added support for choosing whether deployments push images to AWS ECR or GHCR.
  • Updated deployment behavior so the image tag used during rollout matches the selected registry.

• Bug Fixes

  • Re-enabled the production deployment path with clearer conditions for when it runs.
  • Simplified deployment inputs by removing unused values from the workflow call.

[coderabbitai]

📝 Walkthrough

Walkthrough

deploy.yml gains a PUSH_TO_ECR boolean workflow input (default true) that gates GHCR login/pull steps on false and ECR login/push steps on true, with dynamic ECS image tag selection. main.yml re-enables deploy-fcbh conditionally for the scriptoria-prd cluster, passing PUSH_TO_ECR: false and dropping unused tag inputs.

Conditional ECR/GHCR Deploy Routing

Layer / File(s)	Summary
PUSH_TO_ECR input and step gating .github/workflows/deploy.yml	Adds PUSH_TO_ECR boolean input; GHCR steps run only when false, ECR steps run only when true, and ECS deploy selects tag from BUILD_NUMBER or DOCKER_TAG accordingly.
deploy-fcbh job activation .github/workflows/main.yml	Replaces if: false with a cluster-name condition, adds PUSH_TO_ECR: false, and removes BUILD_ENGINE_TAG/OTEL_TAG from the reusable workflow inputs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop left for GHCR, hop right for ECR,
A boolean flag makes the bunny feel sure.
No more if: false to block the deploy,
Scriptoria-prd gets its image with joy.
One input to rule which registry we use—
The rabbit just hops down whichever it choose! 🌟

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main workflow change: updating actions to deploy to the FCBH instance.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/fcbh-deploy

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/deploy.yml:
- Around line 46-52: Pin the external GitHub Actions in the workflow to full
commit SHAs instead of mutable version tags. Update both the docker/login-action
and aws-actions/amazon-ecr-login entries in the deploy workflow’s login steps to
use immutable commit references so the action versions cannot drift
unexpectedly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2957a3d4-7582-4354-811c-61ad7c11dd92

📥 Commits

Reviewing files that changed from the base of the PR and between 8859275 and 3378b02.

📒 Files selected for processing (2)

• .github/workflows/deploy.yml
• .github/workflows/main.yml