Fix silent data loss when record identifier is missing in XmlMergeService#380
Merged
Conversation
…ictionary The IsNullOrEmpty check used 'identifierAttribute' (the parameter name, always non-empty) instead of 'identifier' (the value read from XML). Records with a missing identifier attribute were silently added under a null key rather than triggering a warning and being skipped. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rmunn
approved these changes
Jul 2, 2026
rmunn
left a comment
rmunn
left a comment
Contributor
There was a problem hiding this comment.
This is a good catch; the logic was indeed supposed to flag records that don't have the attribute, which is what the bugfix will do now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In `XmlMergeService.MakeRecordDictionary`, the null-guard tested `identifierAttribute` (the parameter, always validated non-empty) instead of `identifier` (the value read from XML). Records whose identifier attribute was absent in the XML were silently added to the dictionary under a `null` key instead of triggering a warning and being skipped.
Change `identifierAttribute` to `identifier` in the `string.IsNullOrEmpty` call.
Fixes #373
Devin review: https://app.devin.ai/review/sillsdev/chorus/pull/380
This change is