Skip to content

Update usability score thresholds#445

Merged
pmachapman merged 1 commit into
masterfrom
update_usability_thresholds
Jul 1, 2026
Merged

Update usability score thresholds#445
pmachapman merged 1 commit into
masterfrom
update_usability_thresholds

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

These are the updated values from silnlp.


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit June 30, 2026 23:20
@codecov-commenter

codecov-commenter commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.30%. Comparing base (7835067) to head (8014229).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   73.30%   73.30%           
=======================================
  Files         443      443           
  Lines       37203    37204    +1     
  Branches     5110     5110           
=======================================
+ Hits        27272    27273    +1     
  Misses       8805     8805           
  Partials     1126     1126           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).


src/SIL.Machine/QualityEstimation/ChrF3QualityEstimator.cs line 35 at r1 (raw file):

        /// The threshold values used to calculate the usability label for every book or text.
        /// </summary>
        public Thresholds BookThresholds { get; set; } = new Thresholds(greenThreshold: 0.776, yellowThreshold: 0.681);

These values should be constants.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Will any of the changes here need to be ported as well? Are there plans for silnlp to move to using machine.py for this soon so it's easier to keep the code in sync?

@Enkidu93 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).

@pmachapman pmachapman force-pushed the update_usability_thresholds branch from ab01fc7 to 8014229 Compare July 1, 2026 19:29

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will any of the changes here need to be ported as well?

No, as the other changes in that PR are about generating the slope/intercept. Those will eventually be ported to Machine, but not at this stage.

Are there plans for silnlp to move to using machine.py for this soon so it's easier to keep the code in sync?

That is being tracked at sillsdev/machine.py#269

@pmachapman made 2 comments.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on ddaspit and Enkidu93).


src/SIL.Machine/QualityEstimation/ChrF3QualityEstimator.cs line 35 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

These values should be constants.

Done.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman merged commit 2800789 into master Jul 1, 2026
3 of 4 checks passed
@pmachapman pmachapman deleted the update_usability_thresholds branch July 1, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants