Update usability score thresholds#445
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 73.30% 73.30%
=======================================
Files 443 443
Lines 37203 37204 +1
Branches 5110 5110
=======================================
+ Hits 27272 27273 +1
Misses 8805 8805
Partials 1126 1126 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).
src/SIL.Machine/QualityEstimation/ChrF3QualityEstimator.cs line 35 at r1 (raw file):
/// The threshold values used to calculate the usability label for every book or text. /// </summary> public Thresholds BookThresholds { get; set; } = new Thresholds(greenThreshold: 0.776, yellowThreshold: 0.681);
These values should be constants.
Enkidu93
left a comment
There was a problem hiding this comment.
Will any of the changes here need to be ported as well? Are there plans for silnlp to move to using machine.py for this soon so it's easier to keep the code in sync?
@Enkidu93 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
ab01fc7 to
8014229
Compare
pmachapman
left a comment
There was a problem hiding this comment.
Will any of the changes here need to be ported as well?
No, as the other changes in that PR are about generating the slope/intercept. Those will eventually be ported to Machine, but not at this stage.
Are there plans for silnlp to move to using machine.py for this soon so it's easier to keep the code in sync?
That is being tracked at sillsdev/machine.py#269
@pmachapman made 2 comments.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on ddaspit and Enkidu93).
src/SIL.Machine/QualityEstimation/ChrF3QualityEstimator.cs line 35 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
These values should be constants.
Done.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
These are the updated values from silnlp.
This change is