Skip to content

Add chapter-level data counts to execution data#990

Open
Enkidu93 wants to merge 1 commit into
mainfrom
chapter-level-data-counts
Open

Add chapter-level data counts to execution data#990
Enkidu93 wants to merge 1 commit into
mainfrom
chapter-level-data-counts

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes #907

@ddaspit, my only outstanding question is how we'd like to count only pretranslated non-verse text. At the moment, they're all lumped together. We could either not count them at all or count them separately or just lump them in (current behavior). What do you think makes the most sense?


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit July 1, 2026 17:25
@codecov-commenter

codecov-commenter commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.57534% with 117 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.34%. Comparing base (19a4d6b) to head (e52b0c5).

Files with missing lines Patch % Lines
...Shared/Services/WordAlignmentPreprocessBuildJob.cs 0.00% 67 Missing ⚠️
...e.Shared/Services/TranslationPreprocessBuildJob.cs 44.92% 38 Missing ⚠️
...hared/Services/ServalTranslationPlatformService.cs 0.00% 5 Missing ⚠️
...red/Services/ServalWordAlignmentPlatformService.cs 0.00% 5 Missing ⚠️
...l.Machine.Shared/Services/NmtPreprocessBuildJob.cs 90.90% 0 Missing and 1 partial ⚠️
...rval.Machine.Shared/Services/PreprocessBuildJob.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   65.47%   65.34%   -0.13%     
==========================================
  Files         387      388       +1     
  Lines       21747    21932     +185     
  Branches     2770     2782      +12     
==========================================
+ Hits        14238    14332      +94     
- Misses       6472     6560      +88     
- Partials     1037     1040       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Enkidu93

Enkidu93 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

I guess I should add this to Echo as well. I'll add that.

@Enkidu93

Enkidu93 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

I guess I should add this to Echo as well. I'll add that.

I'm realizing that I'll need a Machine dependency in Echo in order to do that. Is that OK or would you prefer to just wait until we complete #987 and let it be resolved there?

@Enkidu93 Enkidu93 force-pushed the chapter-level-data-counts branch from 2363b49 to e52b0c5 Compare July 2, 2026 16:30
@Enkidu93

Enkidu93 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

Our conclusion was that we will only count scripture segments in this new counts data structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partial book drafting chart

2 participants