Add chapter-level data counts to execution data#990
Open
Enkidu93 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
- Coverage 65.47% 65.34% -0.13%
==========================================
Files 387 388 +1
Lines 21747 21932 +185
Branches 2770 2782 +12
==========================================
+ Hits 14238 14332 +94
- Misses 6472 6560 +88
- Partials 1037 1040 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I guess I should add this to Echo as well. I'll add that. |
Collaborator
Author
I'm realizing that I'll need a Machine dependency in Echo in order to do that. Is that OK or would you prefer to just wait until we complete #987 and let it be resolved there? |
2363b49 to
e52b0c5
Compare
Collaborator
Author
|
Our conclusion was that we will only count scripture segments in this new counts data structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #907
@ddaspit, my only outstanding question is how we'd like to count only pretranslated non-verse text. At the moment, they're all lumped together. We could either not count them at all or count them separately or just lump them in (current behavior). What do you think makes the most sense?
This change is