Skip to content

Encode build_options in base64#992

Open
pmachapman wants to merge 2 commits into
mainfrom
build_options_base64
Open

Encode build_options in base64#992
pmachapman wants to merge 2 commits into
mainfrom
build_options_base64

Conversation

@pmachapman

@pmachapman pmachapman commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Partial fix for #966.

Requires: sillsdev/machine.py#330.

I will implement build_option constraints separately in another PR, as those will be implemented at the API boundary.


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit July 2, 2026 02:43
@pmachapman pmachapman force-pushed the build_options_base64 branch from e131616 to ee83242 Compare July 2, 2026 02:59
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.53%. Comparing base (db04610) to head (ee83242).

Files with missing lines Patch % Lines
...ared/Services/StatisticalClearMLBuildJobFactory.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files         387      387           
  Lines       21743    21755   +12     
  Branches     2769     2769           
=======================================
+ Hits        14249    14257    +8     
- Misses       6454     6458    +4     
  Partials     1040     1040           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants