Skip to content

SF-3840 Alert user that available drafting books reflect source text#3977

Open
RaymondLuong3 wants to merge 1 commit into
masterfrom
task/sf-3840-draft-books
Open

SF-3840 Alert user that available drafting books reflect source text#3977
RaymondLuong3 wants to merge 1 commit into
masterfrom
task/sf-3840-draft-books

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

This updates a notice to reflect the change to allow drafting any book available in the source project.

image

This change is Reviewable

@RaymondLuong3 RaymondLuong3 force-pushed the task/sf-3840-draft-books branch from 09df2f1 to d77839e Compare July 2, 2026 20:37
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (dfb04af) to head (d77839e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3977      +/-   ##
==========================================
- Coverage   81.04%   81.04%   -0.01%     
==========================================
  Files         645      645              
  Lines       41434    41431       -3     
  Branches     6748     6748              
==========================================
- Hits        33581    33578       -3     
  Misses       6747     6747              
  Partials     1106     1106              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@marksvc marksvc self-assigned this Jul 3, 2026
@marksvc

marksvc commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

This is reviewable in Devin Review.

@marksvc marksvc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code change. But please consider the comment regarding whether we should even have a message.

@marksvc reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).


-- commits line 2 at r1:
I observe that we came to this situation from another situation where the user might easily not be able to specify a specific book. And so we are revising the UI from that situation, to the new situation. This patch therefore revises the notice text and behaviour in response to the changed situation.

But suppose we started fresh, with no previous behaviour. The user can select any book in the source. And suppose we consider what text would be important to show on the dialog at this point in the process. Would we write this message? I don't think we would.

The drafting task here is representing the situation of "Please select books from the source, that you want to generate a draft for into the target." With that in mind, it seems unnecessary to then say essentially, "If the source doesn't have a book, then check if it has the book."

I think that in-so-far as we have made it clear that the user is generating a draft from a particular source text, we don't need to also tell the user that they can only generate drafts for books that are in that source text.

If we are concerned that the user might not have recently Synchronized their source text, and therefore a desired book is missing from the list, then we could word messaging about that.
If we are concerned that the user might be confused or mixed up about what source text they are meaning to use for draft generation, then we might instead write text at the top of the dialog, under the title, saying, "Select books to draft from your configured drafting source text, NNRV - Nepali New Revised Version 2012". (Only if that's that's the concern.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants