simplerisk: set USE_DATABASE_FOR_SESSIONS to true in config.php#139
Merged
Conversation
The full-stack entrypoint was not substituting the __USE_DATABASE_FOR_SESSIONS__ placeholder shipped in config.sample.php, leaving an invalid value in config.php. Hardcode it to 'true' alongside the other DB substitutions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simplerisk/common/entrypoint.shwas not substituting the__USE_DATABASE_FOR_SESSIONS__placeholder shipped inconfig.sample.php, so the generatedconfig.phpcontaineddefine('USE_DATABASE_FOR_SESSIONS', '__USE_DATABASE_FOR_SESSIONS__');— an invalid value.sedsubstitution alongside the other DB substitutions inset_configthat hardcodes the value totrue.simplerisk-minimalimage already handles this (via theSIMPLERISK_DB_FOR_SESSIONSenv var, defaulting totrue). The full-stack image bundles MySQL and hardcodes all other DB-related values, so keeping this hardcoded matches that pattern — no new env var introduced.Test plan
docker build -t simplerisk/simplerisk:test-uds simplerisk/)/var/www/simplerisk/includes/config.phpcontainsdefine('USE_DATABASE_FOR_SESSIONS', 'true');— no placeholder remaining🤖 Generated with Claude Code