Repository navigation
Publish to the tap and bucket with deploy keys - #50
Merged
Merged
Conversation
HOMEBREW_TAP_DEPLOY_KEY and SCOOP_BUCKET_DEPLOY_KEY each reach one repository. Set, GoReleaser pushes with them over git; unset, the git URL renders empty and the existing token path runs. Token fields stay .Env: GoReleaser 2.18.3 does not define envOrDefault there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets releases publish the Homebrew cask and the Scoop manifest with a write deploy key on each package repository, instead of a personal access token (
TAP_GITHUB_TOKEN). Each deploy key reaches its one repository and nothing else.src/.goreleaser.yaml:homebrew_casksandscoopstake agit:block. Its URL renders only whenHOMEBREW_TAP_DEPLOY_KEY/SCOOP_BUCKET_DEPLOY_KEYis set. With a key, GoReleaser clones, commits and pushes over SSH. Without one, the URL is empty and the existing token path runs unchanged.release.yml: passes the two key secrets next toTAP_GITHUB_TOKEN.skip_uploadalso counts the deploy key, so a keyed release is not skipped.envOrDefault, which GoReleaser does not define intoken:. The release passed until now only because the cask was skipped (no tap token set); it would have failed as soon as one was. They are.Envnow, and the comment explains why.simtabi/homebrew-taprequires a pull request onmain; its ruleset gets Deploy keys as a bypass actor (an owner step), so a release key push lands directly.scoop-buckethas no rules. Nothing changes until the keys exist (created with the deploy-key setup script, on the personal login).Verified locally with GoReleaser 2.18.3 (the version CI's
latestresolves to):goreleaser checkpasses.envOrDefaultis not defined insidetoken:("function envOrDefault not defined"), so the token stays{{ .Env.TAP_GITHUB_TOKEN }}. That form fails only when the variable is entirely unset and no key is given, which CI never does.actionlint shows only the two known stale
create-github-app-token@v3findings, where they apply.