Repository navigation
Give Scoop its own publish switch, SKIP_SCOOP - #51
Merged
Merged
Conversation
Scoop needs only its deploy key, while Winget needs a fork and a token, so one switch kept Scoop off for Winget's reasons. SKIP_SCOOP falls back to SKIP_WINDOWS_PKGS, then to skipped, so nothing changes until it is set. The template uses `or`, not envOrDefault: GoReleaser 2.18.3 treats a set-but-empty variable as set, and an empty skip_upload publishes (measured in a local harness, 7 combinations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives Scoop its own publish switch,
SKIP_SCOOP, separate from winget'sSKIP_WINDOWS_PKGS. Scoop needs only its deploy key (SCOOP_BUCKET_DEPLOY_KEY, now set), while winget needs a fork and a token, so the shared switch kept Scoop off for winget's reasons.scoops.skip_upload:{{ or (envOrDefault "SKIP_SCOOP" "") (envOrDefault "SKIP_WINDOWS_PKGS" "") "true" }}, the first non-empty value.release.ymlpassesSKIP_SCOOP: ${{ vars.SKIP_SCOOP }}.Nothing changes until
SKIP_SCOOPis set: unset or empty, it followsSKIP_WINDOWS_PKGSexactly as before. Set the repository variableSKIP_SCOOP=falseto publish to Scoop while winget stays off.Why
orand notenvOrDefaultwith a fallback: GoReleaser 2.18.3 treats a set-but-empty variable as set, and an emptyskip_uploadpublishes. Measured in a local harness pushing to a bare repository, all 7 combinations: neither set, both empty, scoop empty, and each switch on and off; publish happened only where intended.Checked:
goreleaser checkpasses; actionlint shows only the known stale findings, if any.