Repository navigation
docs: Fix Go SDK README and guide code samples, versions, and links - #204
Open
promptless[bot] wants to merge 2 commits into
Open
promptless[bot] wants to merge 2 commits into
promptless[bot] wants to merge 2 commits into
Conversation
![promptless[bot]](https://avatars.githubusercontent.com/in/979718?s=60&v=4){kind=small}
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
GoSec Findings: No issues found, Good to merge. |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
… signature snippet
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
GoSec Findings: No issues found, Good to merge. |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Why
The Go SDK docs have samples that don't compile against the current SDK, an outdated minimum Go version, and broken anchors and links.
Goal
README.md: raise the Go floor to 1.25.0 to matchv2/go.mod. Make the Quickstart a single program that runs. Add the requiredoptionsargument to 18 calls (Insert, Query, Tokenize, Delete, UploadFile, DeidentifyText, ReidentifyText, DeidentifyFile, GetDetectRun). Fix a broken table-of-contents anchor and a broken in-text link to the bearer-tokens section.docs/advanced_initialization.md: fix a "Python SDK" copy error,:=typos, a missingfmtimport, and add client error handling so the sample compiles and reports initialization errors.docs/auth_credentials.md: correct the credential precedence order.docs/api_reference.mdanddocs/migrate_to_v2.md: correct the casing of response keys.docs/migrate_to_v2.md: fix a dead CHANGELOG link.README-v1.md: fix compile and runtime errors in the samples, such as:=typos, missing struct commas, aConnectionConfigfield type mismatch, an undefined variable, a missing import, an invalidLogLevelselector, and literal types that panic on the v1 type assertions.samples/v2/go.modand CI, the column name in the Query example, which the team should confirm, and stale pre-Fern docs.skyflow.com URLs.Testing
maincommit. Review comments on this PR link each correction to the source line that supports it.Trigger Events