Repository navigation
docs: Fix iOS SDK README requirements, property names, and compile errors - #338
Open
promptless[bot] wants to merge 1 commit into
Open
promptless[bot] wants to merge 1 commit into
promptless[bot] wants to merge 1 commit into
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Why
The iOS SDK READMEs list the wrong minimum iOS version, use property names that don't exist, and include Swift samples that don't compile.
Goal
Skyflow/README.md: change the minimum iOS version to 13.0 to match the podspecs andPackage.swift. Use the real property namerequiredAstrisk(the source misspells it). MarkRevealElementInput.labelas required. Add theenv: .DEVsecurity warning that the FlowVault README already has, because the risk comes from sharedSkyflowCorecode.SKyflowmodule typo,UIColor.BLACK). Add the missingiconStylesparameter to seven signature blocks. Replace a Java-styleArrayList<String>(). Remove references to the removedinvokeConnection()API.getById()method. Correct the claim thatGetSampledemonstrates it. Fix atable/tableNamemismatch in the FlowVault README.Testing
maincommit. Review comments on this PR link each correction to the source line that supports it.Trigger Events