Skip to content

docs: Fix React Native SDK README prop names, anchors, and comments - #166

Open
promptless[bot] wants to merge 1 commit into
mainfrom
promptless/sdk-docs-review
Open

promptless[bot] wants to merge 1 commit into
mainfrom
promptless/sdk-docs-review

Conversation

@promptless

@promptless promptless Bot commented Oct 19, 2026

Copy link
Copy Markdown

Open in Promptless

Why

The React Native SDK README uses a prop name that doesn't exist, so the documented error-text styles are silently dropped. It also has a broken anchor and misleading comments in examples.

Goal

  • README.md: change errorTextStyle to errorTextStyles in 3 places to match the props in src/. Fix the event-listener anchor. Fix onFocus, onBlur, and onReady comments that said they trigger onChange. Remove a duplicate ExpirationDateElement entry and the claim that get() is only for non-PCI use cases, which its own card-number examples contradict. Add Validations and Event Listener to the table of contents.
  • Not in this PR: native iOS and Android setup steps, the setToken ref API, and an error-code reference.

Testing

  • Every corrected identifier, signature, default, version, and link target was checked against the SDK source, build files, and samples in this repository at the current main commit. Review comments on this PR link each correction to the source line that supports it.
  • No SDK code, samples, or build files changed. Builds, tests, and installers were not run.
  • Vale prose checks report no new findings in the changed passages.

Trigger Events

Comment thread README.md
Comment thread README.md
Comment thread README.md
@github-actions

Copy link
Copy Markdown

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions

Copy link
Copy Markdown

Semgrep findings: No issues found, Good to merge.

Comment thread README.md
Comment thread README.md
Comment thread README.md
Comment thread README.md
@promptless

promptless Bot commented Oct 19, 2026

Copy link
Copy Markdown
Author

I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed.

Comment thread README.md
Comment thread README.md
Comment thread README.md
Comment thread README.md
Comment thread README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants