Repository navigation
docs: Fix React Native SDK README prop names, anchors, and comments - #166
Open
promptless[bot] wants to merge 1 commit into
Open
promptless[bot] wants to merge 1 commit into
promptless[bot] wants to merge 1 commit into
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep findings: No issues found, Good to merge. |
Author
|
I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Why
The React Native SDK README uses a prop name that doesn't exist, so the documented error-text styles are silently dropped. It also has a broken anchor and misleading comments in examples.
Goal
README.md: changeerrorTextStyletoerrorTextStylesin 3 places to match the props insrc/. Fix the event-listener anchor. FixonFocus,onBlur, andonReadycomments that said they triggeronChange. Remove a duplicateExpirationDateElemententry and the claim thatget()is only for non-PCI use cases, which its own card-number examples contradict. Add Validations and Event Listener to the table of contents.setTokenref API, and an error-code reference.Testing
maincommit. Review comments on this PR link each correction to the source line that supports it.Trigger Events