Repository navigation
Tests: prompt preview worktree assertion on Windows - #255
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#120 CI on
5c905416fails both Windows Verify jobs ondispatch::tests::a_prompt_preview_renders_like_a_dispatch_and_changes_nothing(from T231, #253): the assertion expected/tsk-t1-ship-dispatch-2 on branch, but Windows renders the worktree path with\\(…\\app\\tsk-t1-ship-dispatch-2 on branch…).tests/cli_dispatch.rsshow_prompt_prints_the_layered_launch_for_any_status_and_writes_nothinghas the same assertion and would fail next (integration tests don't run after a lib failure).Fix: drop the leading separator from both assertions. Test-only; no product change.
Checks (macOS):
cargo fmt --check, both tests pass,cargo clippy --all-targets --target x86_64-pc-windows-gnu -- -D warningsclean. Windows proof is #120's CI after merge.