Skip to content

tsk setup: name both installed skills (T331) - #264

Merged
smarzban merged 3 commits into
mainfrom
tsk/t331-tsk-setup-agents-show-that
Oct 22, 2026
Merged

smarzban merged 3 commits into
mainfrom
tsk/t331-tsk-setup-agents-show-that

Conversation

@smarzban

@smarzban smarzban commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

T331. tsk setup printed only …/tsk-cli/SKILL.md per agent, so it read as if only one skill was installed. tsk-coordinator/SKILL.md was written beside it but never shown.

Change

  • Human output of tsk setup agents [--yes], interactive tsk setup, tsk setup <agent>, --skill-dir: one row per agent, <skills folder> (tsk-cli, tsk-coordinator). The per-agent table stays; rows are about as wide as before (folder is 17 chars shorter than the file path).
  • Interactive prompt: Install or update the tsk skills (tsk-cli, tsk-coordinator) for cursor? [y/N].
  • Bare tsk setup listing shows each agent's skills folder plus one line naming both skills.
  • --json (single and batch): adds skills_root and skills (both file paths). Existing fields unchanged (path is still the tsk-cli file).
  • Untouched: installer probes --skill-states / --detected-ids (verified byte-identical shape below), installers, skills (no version bump needed).
  • tsk setup --help action rows say "both skills".
  • Docs: cli.md setup section (both skills, output line, example). CHANGELOG Unreleased → Changed.

Proof (release build, isolated HOME, TSK_STATE_DIR, XDG_*, PATH; $TMP = scratch dir)

$ tsk setup --skill-dir ./sd
./sd  (tsk-cli, tsk-coordinator)
$ tsk setup agents --yes
    claude   $TMP/home/.claude/skills  (tsk-cli, tsk-coordinator)
    cursor   $TMP/home/.cursor/skills  (tsk-cli, tsk-coordinator)
$ tsk setup claude --force
$TMP/home/.claude/skills  (tsk-cli, tsk-coordinator)
$ tsk setup agents --yes --json   (cursor skills removed first)
{"applied":[{"id":"cursor","kind":"written","path":"$TMP/home/.cursor/skills/tsk-cli/SKILL.md","skills":["…/tsk-cli/SKILL.md","…/tsk-coordinator/SKILL.md"],"skills_root":"$TMP/home/.cursor/skills"}],…,"skipped_current":["claude"]}
$ tsk setup --skill-states   (unchanged)
embedded	1.6.0
claude	current	1.6.0	$TMP/home/.claude/skills/tsk-cli/SKILL.md
cursor	current	1.6.0	$TMP/home/.cursor/skills/tsk-cli/SKILL.md

Files on disk: sd/, .claude/skills/, .cursor/skills/ each hold tsk-cli/SKILL.md and tsk-coordinator/SKILL.md.

Checks

  • Green bar (fmt --check, clippy -D warnings, cargo test): pass.
  • cargo clippy --all-targets --target x86_64-pc-windows-gnu -- -D warnings: pass (compile/lint only).
  • Windows tests (userprofile_only_drives_windows_skill_install_and_listing, updated to the new listing and install line): covered by CI Windows Verify only, not run locally.
  • cd site && npm test: 58 pass.
  • Regression: reverting the presenter hunk fails skill_dir_writes_full_skill_prints_path_exits_0 and setup_agent_batch_prints_padded_rows_for_each_outcome.
  • Live Herdr smoke: not applicable (no board/pane change), not run.

Not in this PR

  • The installers' own prompts (Install the tsk skill for them?, Updated the tsk skill for …) still say "skill" singular; changing them runs the Installer workflow and packaging tests. Separate task if wanted.

@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
herdr-tsk Ignored Ignored Preview Oct 22, 2026 12:01pm UTC

@smarzban
smarzban merged commit 6f7d1dd into main Oct 22, 2026
8 checks passed
@smarzban
smarzban deleted the tsk/t331-tsk-setup-agents-show-that branch October 22, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant