Skip to content

Commit 5586aca

Browse files
committed
fix: fix string compare lint warnings
1 parent 54becd8 commit 5586aca

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -430,8 +430,8 @@ public CompletableFuture<ShowDocumentResult> showDocument(ShowDocumentParams par
430430
SnykLogger.logInfo(String.format("Invalid URI: 'issueId' empty"));
431431
}
432432

433-
if (scheme.equals("snyk") && product.equals(DIAGNOSTIC_SOURCE_SNYK_CODE)
434-
&& action.equals("showInDetailPanel")) {
433+
if ("snyk".equals(scheme) && product.equals(DIAGNOSTIC_SOURCE_SNYK_CODE)
434+
&& "showInDetailPanel".equals(action)) {
435435
return CompletableFuture.supplyAsync(() -> {
436436

437437
Issue issue = getIssueFromCache(uri);
@@ -481,11 +481,12 @@ public static Map<String, String> parseQueryString(String queryString) {
481481
return paramMap;
482482
}
483483

484+
int keyValueSize = 2;
484485
for (String param : queryString.split("&")) {
485486
if (!param.isEmpty()) {
486487
String[] keyValue = param.split("=");
487488

488-
if (keyValue.length == 2) {
489+
if (keyValue.length == keyValueSize) {
489490
try {
490491
paramMap.put(keyValue[0], URLDecoder.decode(keyValue[1], "UTF-8"));
491492
} catch (UnsupportedEncodingException e) {

0 commit comments

Comments
 (0)