fix: lint improvements

Author: acke

plugin/.pmd

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <pmd>
     <useProjectRuleSet>true</useProjectRuleSet>
-    <ruleSetFile>/Users/skippy/repos/snyk-eclipse-plugin/plugin/src/main/resources/pmd-ruleset.xml</ruleSetFile>
+    <ruleSetFile>src/main/resources/pmd-ruleset.xml</ruleSetFile>
     <includeDerivedFiles>false</includeDerivedFiles>
     <violationsAsErrors>true</violationsAsErrors>
     <fullBuildEnabled>true</fullBuildEnabled>

plugin/src/main/java/io/snyk/eclipse/plugin/properties/FolderConfigs.java

@@ -76,7 +76,8 @@ public FolderConfigsParam updateFolderConfigs() {
 
 		for (var project : openProjects) {
 			Path path = ResourceUtils.getFullPath(project);
-			IScopeContext projectScope = new ProjectScope(project); //NOPMD
+			//Linter does not like when new objects are created in loops, but here we do want to create new ProjectScopes in the loop.
+			IScopeContext projectScope = new ProjectScope(project); //NOPMD, 
 			var projectSettings = projectScope.getNode(Activator.PLUGIN_ID);
 			String additionalParams = projectSettings.get(ProjectPropertyPage.SNYK_ADDITIONAL_PARAMETERS, "");
 			var additionalParamsList = Arrays.asList(additionalParams.split(" "));

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/IssueTreeNode.java

@@ -11,7 +11,7 @@ public class IssueTreeNode extends BaseTreeNode {
 
 	public IssueTreeNode(Issue issue) {
 		super(issue);
-		this.issue = issue;
+		this.setIssue(issue);
 	}
 
 	@Override
@@ -44,7 +44,7 @@ public Issue getIssue() {
 		return issue;
 	}
 
-	public void setIssue(Issue issue) {
+	public final void setIssue(Issue issue) {
 		this.issue = issue;
 	}
 

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/filters/BaseFilter.java

@@ -5,14 +5,14 @@
 import io.snyk.eclipse.plugin.preferences.Preferences;
 import io.snyk.eclipse.plugin.views.snyktoolview.TreeFilterManager;
 
-@SuppressWarnings({ "rawtypes"})
-public class BaseFilter {
+@SuppressWarnings({"rawtypes"})
+public abstract class BaseFilter {
 	protected Preferences preferences = Preferences.getInstance();
 	protected TreeFilterManager filterManager;
 	protected String filterName;
 	protected Predicate predicate;
 
-	protected BaseFilter(String filterName, Predicate predicate, TreeFilterManager tfm) {
+	public BaseFilter(String filterName, Predicate predicate, TreeFilterManager tfm) {
 		this.filterName = filterName;
 		this.predicate = predicate;
 		this.filterManager = tfm;

plugin/src/main/java/io/snyk/languageserver/LsConfigurationUpdater.java

@@ -209,7 +209,7 @@ public String getAutomaticAuthentication() {
 		}
 
 		public String[] getTrustedFolders() {
-			return Arrays.copyOf(trustedFolders, trustedFolders.length);
+			return trustedFolders.clone();
 		}
 
 		public String getEnableTrustedFoldersFeature() {

plugin/src/main/java/io/snyk/languageserver/protocolextension/messageObjects/PublishDiagnostics316Param.java

@@ -20,41 +20,44 @@ public void setUri(String uri) {
 	}
 
 	public Diagnostic316[] getDiagnostics() {
-	    if (diagnostics == null) {
-	        return new Diagnostic316[0]; // Return an empty array if diagnostics is null
-	    }
-	    return Arrays.copyOf(diagnostics, diagnostics.length);
+		if (diagnostics == null) {
+			return null;
+		}
+		return diagnostics.clone();
 	}
 
-
 	public void setDiagnostics(Diagnostic316... diagnostics) {
+		if (diagnostics == null) {
+			this.diagnostics = null;
+		}
 		this.diagnostics = diagnostics.clone();
 	}
 
 	@Override
 	public int hashCode() {
-	    final int prime = 31;
-	    int result = 1;
-	    result = prime * result + (diagnostics == null ? 0 : Arrays.hashCode(diagnostics));
-	    result = prime * result + Objects.hash(uri);
-	    return result;
+		final int prime = 31;
+		int result = 1;
+		result = prime * result + (diagnostics == null ? 0 : Arrays.hashCode(diagnostics));
+		result = prime * result + Objects.hash(uri);
+		return result;
 	}
 
 	@Override
 	public boolean equals(Object obj) {
-	    if (this == obj)
-	        return true;
-	    if (obj == null)
-	        return false;
-	    if (getClass() != obj.getClass())
-	        return false;
-	    PublishDiagnostics316Param other = (PublishDiagnostics316Param) obj;
-	    return (diagnostics == null ? other.diagnostics == null : Arrays.equals(diagnostics, other.diagnostics)) 
-	           && Objects.equals(uri, other.uri);
+		if (this == obj)
+			return true;
+		if (obj == null)
+			return false;
+		if (getClass() != obj.getClass())
+			return false;
+		PublishDiagnostics316Param other = (PublishDiagnostics316Param) obj;
+		return (diagnostics == null ? other.diagnostics == null : Arrays.equals(diagnostics, other.diagnostics))
+				&& Objects.equals(uri, other.uri);
 	}
 
 	@Override
 	public String toString() {
-	    return "PublishDiagnostic316Param [uri=" + uri + ", diagnostics=" + (diagnostics == null ? "null" : Arrays.toString(diagnostics)) + "]";
+		return "PublishDiagnostic316Param [uri=" + uri + ", diagnostics="
+				+ (diagnostics == null ? "null" : Arrays.toString(diagnostics)) + "]";
 	}
 }

plugin/src/main/java/io/snyk/languageserver/protocolextension/messageObjects/SnykTrustedFoldersParams.java

@@ -1,12 +1,10 @@
 package io.snyk.languageserver.protocolextension.messageObjects;
 
-import java.util.Arrays;
-
 public class SnykTrustedFoldersParams {
   private String[] trustedFolders;
 
   public String[] getTrustedFolders() {
-    return Arrays.copyOf(trustedFolders, trustedFolders.length);
+    return trustedFolders.clone();
   }
 
   public void setTrustedFolders(String... trustedFolders) {

plugin/src/main/java/io/snyk/languageserver/protocolextension/messageObjects/scanResults/Issue.java

@@ -4,23 +4,20 @@
 
 public record Issue(String id, String title, String severity, String filePath, Range range, boolean isIgnored,
 		boolean isNew, String filterableIssueType, IgnoreDetails ignoreDetails, AdditionalData additionalData) {
-
 	public String getDisplayTitle() {
 		if (title == null || title.isEmpty()) {
 			return additionalData != null ? additionalData.message() : null;
 		}
-
-		StringBuilder displayTitle = new StringBuilder(title);
-
+		String displayTitle = title;
 		if (isIgnored()) {
-			displayTitle.insert(0, " [ Ignored ] ");
+			displayTitle = " [ Ignored ] " + displayTitle;
 		}
 
 		if (hasFix()) {
-			displayTitle.insert(0, " ⚡");
+			displayTitle = " ⚡" + displayTitle;
 		}
-
-		return displayTitle.toString();
+		
+		return displayTitle;
 	}
 
 	public String getDisplayTitleWithLineNumber() {
@@ -53,17 +50,20 @@ public Boolean hasFix() {
 		}
 		return additionalData.hasAIFix() || additionalData.isUpgradable();
 	}
-
+	
 	public Boolean isVisible(Boolean includeIgnoredIssues, Boolean includeOpenedIssues) {
-		if (includeIgnoredIssues && includeOpenedIssues) {
-			return true;
-		}
-		if (includeIgnoredIssues) {
-			return this.isIgnored();
-		}
-		if (includeOpenedIssues) {
-			return !this.isIgnored();
-		}
-		return false;
-	}
+        if (includeIgnoredIssues && includeOpenedIssues)
+        {
+            return true;
+        }
+        if (includeIgnoredIssues)
+        {
+            return this.isIgnored();
+        }
+        if (includeOpenedIssues)
+        {
+            return !this.isIgnored();
+        }
+        return false;
+	}	
 }