Repository navigation
Conversation
Signed-off-by: Ateş Göral <ates.goral@shopify.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in
maximum_receive_message_size:client option, backed byProtocol::GRPC::Body::Readable'smaximum_size:option.nil(unlimited)..openand inherited or explicitly overridden by.with.Unlimited clients omit the new reader keyword, preserving compatibility with earlier
protocol-grpcreleases.Companion dependency
This is a draft companion to protocol-grpc's receive-size option. A configured limit needs a released
protocol-grpcversion supportingmaximum_size:; published 0.17.0 does not. This draft must not merge until that companion is released and the minimum dependency is updated accordingly. No speculative release version or fork dependency is committed here.Validation
Local validation on Ruby 4.0.7:
protocol-grpc0.17.0, without the companion overlay: 84 tests passed, 201 assertions.The new HTTP/1 and HTTP/2 tests cover all four RPC patterns, exact and oversized responses, construction/inheritance and unrestricted request sizes. Compression integration tests cover unary gzip/deflate expansion; the final-status regression covers an in-limit unary response with real final non-OK trailers.
CI cannot exercise the configured limit with only the currently published reader; cross-repository release/dependency coordination is required.
Separate lifecycle follow-up
The existing bidirectional error-cleanup behavior is unchanged. A local HTTP/1 probe found that an exception before the caller closes its output can leave the request writer open and pool capacity held on both baseline and candidate code. This receive-size patch does not repair that separate lifecycle gap.